Repository navigation
feat(cli): group the report options, and open the report only on request - #216
Merged
Merged
Conversation
safl
force-pushed
the
report-open-opt-in
branch
from
October 23, 2026 10:09
6c63af1 to
c8bda30
Compare
safl
force-pushed
the
report-open-opt-in
branch
from
October 23, 2026 10:27
c8bda30 to
6d857e0
Compare
Every task-run ended by opening report.html in a browser unless -s was given, which on a desktop pops a window after each run and is never wanted in CI or over SSH, and the three report options were spelled three different ways. The report is still written by default; the options are now --report-open to also open it, --report-skip to not write it, and --report-only to write it for an existing output and exit. -n/--no-report and -p/--produce-report keep working as deprecated spellings of --report-skip and --report-only, and -s/--skip-report is accepted and ignored, each with a warning. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Simon A. F. Lund <os@safl.dk>
safl
force-pushed
the
report-open-opt-in
branch
from
October 23, 2026 10:37
6d857e0 to
ccdf1bb
Compare
Coverage Report for CI Build 39940480497Coverage decreased (-4.8%) to 71.027%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
naddinadja
approved these changes
Oct 23, 2026
naddinadja
left a comment
naddinadja
left a comment
Contributor
There was a problem hiding this comment.
Great! I love that the report opens automatically, so I just have to remember to add that argument each time 😂
Collaborator
Author
|
xNVMe exercises this together with #214 and #215 in xnvme/xnvme#825, which pins cijoe to the preview branch |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report is still written at the end of every task-run, but no longer opened in a browser unless asked for; on a desktop it popped a window after each run, which nobody wants in CI or over SSH. The three report options, which were spelled three different ways, become one group:
report.html, do not open it--report-open--report-skip-n/--no-report--report-only-oand exit; with--report-open, also open it-p/--produce-reportWorth a look: the old options keep working for now.
-n/--no-reportand-p/--produce-reportmap onto--report-skipand--report-only, and-s/--skip-reportis accepted and ignored, since not opening is now the default; each logs a deprecation warning and is hidden from--help, as-w/--workflowwas.--report-skipwith--report-onlyis rejected.--report-openis stored apart fromcore.reporter's ownreport_openargument, so a task can still usecore.reporteras a step, with or without setting it. The shell completions list both spellings. The quickstart indocs/source/index.rst, the docs-build command in250_quickstart.cmdandtests/core/test_loglevel.pyuse the new options.docs/source/050_usage_help.outstill shows the old help; it looks generated, so it is left to the docs build.Verification:
tests/core/test_report_args.pycovers the defaults, the conflict and each deprecated spelling, andtests/core/test_report_open.pyruns a one-step task in-process withwebbrowser.openpatched, checking that the report is written and opened, or not, for no option,--report-open,--report-skipand-s, and runscore.reporteras a task step with and without its argument. 12 of these 15 fail onmain. Three pass there too: the-scase, since-salready meant "write, do not open", and the twocore.reporterstep cases, which guard against breaking what works onmain.