Make the onPreview() callback asynchronous.#116
Open
nud wants to merge 1 commit intorefactory-id:masterfrom
nud:async-preview
Open
Make the onPreview() callback asynchronous.#116nud wants to merge 1 commit intorefactory-id:masterfrom nud:async-preview
nud wants to merge 1 commit intorefactory-id:masterfrom
nud:async-preview
Conversation
This makes it possible to perform asynchronous operations while in the
onPreview() callback, for instance using an AJAX request:
$("#form_content").markdown({
onPreview: function(editor, callback) {
jQuery.ajax({
type: "POST",
url: "/render-markdown",
data: { content: editor.$textarea.val() },
success: callback
});
}
});
A default implementation of onPreview() is provided, using an updated
parseContent() method which doesn't call the onPreview() callback
anymore.
This effectively adds a parameter to the onPreview() callback, but
backward compatibility is retained by checking the onPreview() callback
return value and using it if it exists.
Closed
Member
|
Hey @nud Can you give me an edge-case whereas we need the |
Author
|
Well the case is in the pull request: you need an async callback if you want to do the markdown rendering server-side, which is needed if you want to do fancy stuff in the markdown rendering. Doing a synchronous ajax call as two downsides:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to perform asynchronous operations while in the
onPreview() callback, for instance using an AJAX request:
A default implementation of onPreview() is provided, using an updated
parseContent() method which doesn't call the onPreview() callback
anymore.
This effectively adds a parameter to the onPreview() callback, but
backward compatibility is retained by checking the onPreview() callback
return value and using it if it exists.