Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,27 @@ upcoming release can be found in [changelog.d](changelog.d).

<!-- towncrier release notes start -->

## [4.7.0](https://github.com/Backblaze/B2_Command_Line_Tool/releases/tag/v4.7.0) - 2026-05-05


### Removed

- Drop support for Python 3.9 and PyPy 3.9.

### Fixed

- Reject unsafe remote filenames in the Download command.

### Infrastructure

- Bump PyInstaller version and remove obsolete hidden imports from the PyInstaller spec file.
- Bump pytest and other test dependencies versions.
- Bump sdk version to v2.12.0.
- Fix tests with pytest 9.0.
- Migrate from pdm to uv.
- Rewrite the test case verifying non-UTF-8 help rendering, replacing subtests with parametrization, cover nested commands.


## [4.6.0](https://github.com/Backblaze/B2_Command_Line_Tool/releases/tag/v4.6.0) - 2026-02-25


Expand Down
8 changes: 8 additions & 0 deletions b2/_internal/console_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
points_to_fifo,
substitute_control_chars,
unprintable_to_hex,
validate_b2_file_name_as_path,
)
from b2sdk.v3.exception import (
B2Error,
Expand Down Expand Up @@ -1960,6 +1961,13 @@ def get_local_output_filepath(
if not output_filepath.is_dir():
return output_filepath

# Make sure the remote filename is safe to interpret as a local path
try:
validate_b2_file_name_as_path(str(file_request.download_version.file_name))
except ValueError as exc:
err_msg = unprintable_to_hex(f'{exc}: {output_filepath}')
raise CommandError(err_msg) from exc

# If the output is directory, we're expected to download the file right there.
# Normally, we overwrite the target without asking any questions, but in this case
# user might be oblivious of the actual mistake he's about to commit.
Expand Down
1 change: 0 additions & 1 deletion changelog.d/+drop-python-3.9.removed.md

This file was deleted.

1 change: 0 additions & 1 deletion changelog.d/+non-utf8-test-redesign.infrastructure.md

This file was deleted.

1 change: 0 additions & 1 deletion changelog.d/+pdm-to-uv.infrastructure.md

This file was deleted.

1 change: 0 additions & 1 deletion changelog.d/+pyinstaller-6.infrastructure.md

This file was deleted.

1 change: 0 additions & 1 deletion changelog.d/+pytest-9.0.infrastructure.md

This file was deleted.

1 change: 0 additions & 1 deletion changelog.d/+pytest.infrastructure.md

This file was deleted.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
dependencies = [
"argcomplete>=3.5.2,<4",
"arrow>=1.0.2,<2.0.0",
"b2sdk>=2.10.3,<3",
"b2sdk>=2.12.0,<3",
"docutils>=0.18.1,<0.22",
"idna~=3.4; platform_system == 'Java'",
"rst2ansi==0.1.5",
Expand Down
52 changes: 51 additions & 1 deletion test/unit/console_tool/test_download_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def test_download_file_by_name__to_stdout_by_alias(

def test_cat__b2_uri(b2_cli, bucket, uploaded_stdout_txt, tmp_path, capfd):
b2_cli.run(
['file', 'cat', '--no-progress', f"b2://{bucket}/{uploaded_stdout_txt['fileName']}"],
['file', 'cat', '--no-progress', f'b2://{bucket}/{uploaded_stdout_txt["fileName"]}'],
)
assert capfd.readouterr().out == uploaded_stdout_txt['content']

Expand Down Expand Up @@ -233,3 +233,53 @@ def test__download_file__threads(b2_cli, local_file, uploaded_file, tmp_path):

assert output_path.read_text() == uploaded_file['content']
assert b2_cli.console_tool.api.services.download_manager.get_thread_pool_size() == num_threads


@pytest.mark.parametrize(
'remote_name',
[
'../escape.txt',
'foo/../bar.txt',
],
)
def test_download_file_by_uri__directory_rejects_unsupported_server_name(
b2_cli, api_bucket, tmp_path, remote_name
):
uploaded_file = api_bucket.upload_bytes(b'hello world', remote_name)
output_directory = tmp_path / 'downloads'
output_directory.mkdir()

b2_cli.run(
[
'file',
'download',
'--no-progress',
f'b2id://{uploaded_file.id_}',
str(output_directory),
],
expected_status=1,
expected_stderr=None,
)

local_path = (output_directory / remote_name).resolve()
assert not local_path.exists()


def test_download_file_by_uri__explicit_file_target_allows_unsupported_server_name(
b2_cli, api_bucket, tmp_path
):
uploaded_file = api_bucket.upload_bytes(b'hello world', '../escape.txt')
output_path = tmp_path / 'output.txt'

b2_cli.run(
[
'file',
'download',
'--no-progress',
f'b2id://{uploaded_file.id_}',
str(output_path),
],
expected_stderr=None,
)

assert output_path.read_text() == 'hello world'
8 changes: 4 additions & 4 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading