Skip to content

bundling adjustments to create apis that can be referenced in rsc#4675

Open
phryneas wants to merge 2 commits into
masterfrom
pr/rsc
Open

bundling adjustments to create apis that can be referenced in rsc#4675
phryneas wants to merge 2 commits into
masterfrom
pr/rsc

Conversation

@phryneas

Copy link
Copy Markdown
Member

No description provided.

@codesandbox

codesandbox Bot commented Oct 27, 2024

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codesandbox-ci

codesandbox-ci Bot commented Oct 27, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8463f69:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify

netlify Bot commented Oct 27, 2024

Copy link
Copy Markdown

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 8463f69
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/671e37b6a80f2600086b843a
😎 Deploy Preview https://deploy-preview-4675--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented Oct 27, 2024

Copy link
Copy Markdown

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/query/react (modern.mjs) 15.33 KB (+13.19% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (modern.mjs) 2.25 KB (+3102.78% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 24.47 KB (+0.34% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs, production.min.cjs) 2.82 KB (-0.07% 🔽)
3. createApi (react) (.modern.mjs) 15.65 KB (+0.17% 🔺)

Comment thread packages/toolkit/src/query/react/module.ts Outdated
Co-authored-by: Arya Emami <aryaemami59@yahoo.com>
const createApi = /* @__PURE__ */ buildCreateApi(
coreModule(),
reactHooksModule(),
reactHooksModule()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reactHooksModule()
reactHooksModule(),

ReducerPath extends string,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
TagTypes extends string,
TagTypes extends string

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TagTypes extends string
TagTypes extends string,

usePrefetch<EndpointName extends QueryKeys<Definitions>>(
endpointName: EndpointName,
options?: PrefetchOptions,
options?: PrefetchOptions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options?: PrefetchOptions
options?: PrefetchOptions,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants