Repository navigation
reactor: Use std::deque as the task queue container - #323
Merged
Merged
Conversation
Avoid oversized allocs on task bursts. chunked_fifo is not usable as is as it doesn't support front insertion as is needed for urgent tasks.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the task queue’s switch to std::deque.
No open issues 🎉
What changed in this PR
Switches the reactor task queue from circular_buffer to std::deque to avoid oversized allocations during task bursts while preserving front insertion for urgent tasks.
Changes:
- Adds
<deque>and changes the task queue container type. - Updates both shuffle helper signatures to accept the new container.
| File | Description |
|---|---|
src/core/reactor.cc |
Adapts shuffle helpers to std::deque<task*>. |
include/seastar/core/reactor.hh |
Includes <deque> and changes the task queue storage type. |
Review effort: Balanced
Member
|
xref: scylladb#3138 That change hasn't been able to make it in, but this PR seems pretty much strictly better than the status quo while being less controversial than 3138. |
travisdowns
approved these changes
Oct 28, 2026
Member
|
LGTM, lets do a microbench slash on the RP side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid oversized allocs on task bursts.
chunked_fifo is not usable as is as it doesn't support front insertion
as is needed for urgent tasks.