Skip to content

Give pipeline-management-v2 its own standalone page - #6502

Merged
ArtemHoruzhenko merged 2 commits into
mainfrom
feature/rdi-ui/pipeline-management-v2-standalone-page
Sep 14, 2026
Merged

Give pipeline-management-v2 its own standalone page#6502
ArtemHoruzhenko merged 2 commits into
mainfrom
feature/rdi-ui/pipeline-management-v2-standalone-page

Conversation

@ArtemHoruzhenko

@ArtemHoruzhenko ArtemHoruzhenko commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • PipelineManagementV2Page was nested under RdiInstancePage, so it inherited the v1 shell's Pipeline/Analytics tabs (AppNavigation) and pipeline status bar (RdiPipelineHeader) - chrome that reads v1's own pipeline REST API and has no relationship to the v2 experience.
  • Moved Pages.rdiPipelineManagementV2 to a top-level route (placed before Pages.rdiPipeline so it isn't swallowed by that route's non-exact prefix match), and the page now renders its own RdiInstanceHeader breadcrumb directly instead of relying on the v1 shell for it.
  • Extracted the shared instance-loading bootstrap (fetch instance list, fetch connected instance, reset stale context) into useConnectRdiInstance, used by both RdiInstancePage and the new standalone page, so instance loading behaves identically either way.

Test plan

  • npx jest on pages/rdi, components/main-router, components/navigation-menu - 66/66 suites, 465 passed / 11 skipped
  • eslint --fix on all touched files - 0 errors
  • tsc --noEmit - no new errors introduced (confirmed via stash comparison against main)
Before After
image image
🤖 Generated with Claude Code

Note

Low Risk
Routing and layout refactor for an RDI feature-flagged page; shared hook preserves prior instance-connection behavior with limited blast radius.

Overview
Pipeline management v2 is no longer nested under the v1 RDI instance shell. Its route is registered as a top-level, exact RDI path (before the broader rdiPipeline prefix) so it is not wrapped by RdiInstancePage tabs and pipeline status chrome.

The v2 page now renders its own RdiInstanceHeader and ExplorePanelTemplate layout while keeping the placeholder content. Instance bootstrap (load lists, connect RDI instance, reset DB/RDI context) is moved into useConnectRdiInstance, shared by RdiInstancePage and PipelineManagementV2Page.

Tests assert the v2 page shows breadcrumbs but not v1 pipeline/status navigation controls.

Reviewed by Cursor Bugbot for commit 5a408a0. Bugbot is set up for automated code reviews on this repo. Configure here.

PipelineManagementV2Page was nested under RdiInstancePage, so it
inherited the v1 shell's Pipeline/Analytics tabs (AppNavigation) and
pipeline status bar (RdiPipelineHeader) - chrome that reads v1's own
pipeline REST API and has no relationship to the v2 experience.

Move Pages.rdiPipelineManagementV2 to a top-level route (placed before
Pages.rdiPipeline so it isn't swallowed by that route's non-exact
prefix match), and have the page render its own RdiInstanceHeader
breadcrumb directly instead of relying on the v1 shell for it.

Extract the shared instance-loading bootstrap (fetch instance list,
fetch connected instance, reset stale context) into
useConnectRdiInstance, used by both RdiInstancePage and the new
standalone page, so instance loading behaves identically either way.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ArtemHoruzhenko
ArtemHoruzhenko requested a review from a team as a code owner September 14, 2026 07:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de4f096d78

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread redisinsight/ui/src/pages/rdi/pipeline-management-v2/PipelineManagementV2Page.tsx Outdated
Comment thread redisinsight/ui/src/pages/rdi/pipeline-management-v2/styles.module.scss Outdated
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.65% 29001/34671
🟡 Branches 69.77% 12355/17707
🟡 Functions 78.69% 7642/9711
🟢 Lines 84.11% 28192/33519

Test suite run success

8099 tests passing in 874 suites.

Report generated by 🧪jest coverage report action from 5a408a0

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit de4f096. Configure here.

Comment thread redisinsight/ui/src/pages/rdi/pipeline-management-v2/PipelineManagementV2Page.tsx Outdated
- Don't reuse RdiInstancePageTemplate for the standalone v2 page: it
  hardcodes a -210px height offset sized for the v1 shell's
  AppNavigation tabs + RdiPipelineHeader status bar, neither of which
  this page renders. Use ExplorePanelTemplate directly instead, which
  lets the page fill its actual available height.
- Move the page wrapper's padding from a hardcoded 16px in an SCSS
  module to a styled-components PageContainer using theme spacing
  (space200), matching repo convention.
- Drop the explanatory comments added for this change - not required
  here.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ArtemHoruzhenko
ArtemHoruzhenko merged commit 3158de7 into main Sep 14, 2026
25 checks passed
@ArtemHoruzhenko
ArtemHoruzhenko deleted the feature/rdi-ui/pipeline-management-v2-standalone-page branch September 14, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants