Skip to content

chore: remove redundant direct dependency on @typescript-eslint/parser - #1357

Merged
shin19991207 merged 2 commits into
redhat-developer:mainfrom
noritaka1166:remove-direct-typescript-eslint-parser
Oct 7, 2026
Merged

shin19991207 merged 2 commits into
redhat-developer:mainfrom
noritaka1166:remove-direct-typescript-eslint-parser

Conversation

@noritaka1166

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the redundant direct devDependency on @typescript-eslint/parser and updates the lockfile.

The dependency was introduced in commit 686efcb (“migrate to eslint”) on June 13, 2020, when .eslintrc.js explicitly selected it as the parser.

The direct dependency became unnecessary in commit 3ef7419 (“Upgrade eslint to version 9”) on May 19, 2026. That commit replaced .eslintrc.js with eslint.config.mjs and switched to typescript-eslint’s recommended configuration. typescript-eslint provides the parser as a dependency, so ESLint continues to use it after this change.

What issues does this PR fix or reference?

None.

Is it tested? How?

  • npm run lint passes.
  • npm ls @typescript-eslint/parser confirms the parser remains a transitive dependency of typescript-eslint.

@shin19991207

Copy link
Copy Markdown
Member

You're right. I checked https://typescript-eslint.io/packages/typescript-eslint/. typescript-eslint already depends on @typescript-eslint/parser, so the direct dependency is redundant.

Thanks, Noritaka!

@shin19991207
shin19991207 merged commit 2c1cd23 into redhat-developer:main Oct 7, 2026
4 checks passed
@shin19991207 shin19991207 added this to the 1.25.0 milestone Oct 7, 2026
@noritaka1166
noritaka1166 deleted the remove-direct-typescript-eslint-parser branch October 7, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants