Make formatter settings resource scoped - #1287
Merged
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
2 tasks done
datho7561
approved these changes
Oct 1, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks, Morgan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes YAML formatter preferences from the implicit
windowscope toresourcescope.What issues does this PR fix or reference?
Fixes #1240
Is it tested? How?
Manually tested with redhat-developer/yaml-language-server#1350 in a multi-root workspace with different formatter settings for each workspace folder. When hovering over the formatter settings, it should show the formatter settings' description instead of
This setting cannot be applied in this workspace. It will be applied when you open the containing workspace folder directly.