Skip to content

fix: pass ollama model name to LLmResponseBuilder #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaidyanath-b wants to merge 3 commits into from
Closed

fix: pass ollama model name to LLmResponseBuilder #190

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9a726a
Use audio/video realtime input instead of deprecated media.
Aug 11, 2026
2ef8fc4
Stamp Ollama LlmResponse.modelVersion from configured model name.
Aug 11, 2026
d7a6b2b
Revert "Use audio/video realtime input instead of deprecated media."
Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/com/google/adk/models/OllamaBaseLM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,9 @@ public Flowable<LlmResponse> generateContent(LlmRequest llmRequest, boolean stre
if (usageMetadata != null) {
responseBuilder.usageMetadata(usageMetadata);
}
// Populate modelVersion so downstream token logging (e.g. rae_tokens) can resolve
// the model name instead of falling back to "unknown".
responseBuilder.modelVersion(this.model());

return Flowable.just(responseBuilder.build());
}
Expand Down Expand Up @@ -590,6 +593,7 @@ private Flowable<LlmResponse> createRobustStreamingResponse(
if (usageMetadata != null) {
aggregatedResponseBuilder.usageMetadata(usageMetadata);
}
aggregatedResponseBuilder.modelVersion(this.model());

responsesToEmit.add(aggregatedResponseBuilder.build());
}
Expand All @@ -612,6 +616,7 @@ private Flowable<LlmResponse> createRobustStreamingResponse(
if (usageMetadata != null) {
functionResponseBuilder.usageMetadata(usageMetadata);
}
functionResponseBuilder.modelVersion(this.model());

responsesToEmit.add(functionResponseBuilder.build());
} catch (Exception funcEx) {
Expand Down Expand Up @@ -653,6 +658,7 @@ private LlmResponse createTextResponse(String text, boolean partial) {
return LlmResponse.builder()
.content(Content.builder().role("model").parts(Part.fromText(text)).build())
.partial(partial)
.modelVersion(this.model())
.build();
}

Expand Down
Loading