Fix parameter spacing when adding a type to a later parameter - #14
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
September 13, 2026 18:36
The injected type node had no leading whitespace, so on any parameter after the first the space that belonged before the variable ended up after the type, producing output like `($a,string $b)`. Move the variable's leading whitespace onto the new type and separate the type from the variable with a single space. This keeps the comma spacing, modifier spacing and multiline indentation intact.
TomasVotruba
force-pushed
the
fix-param-spacing
branch
from
September 13, 2026 18:39
0b0cd2b to
b22d32e
Compare
TomasVotruba
disabled auto-merge
September 13, 2026 18:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while running the tool on a real project.
Bug
The injected type node carried no leading whitespace. On any parameter after the first, the space that belonged before the variable was printed after the type instead, and doubled up:
Same issue with promoted constructor params (
private bool $guest).Fix
Move the variable's original leading whitespace onto the new type, and separate the type from the variable with a single space. Comma spacing, modifier spacing and multiline indentation are all preserved:
Regression tests cover a later parameter, a promoted constructor parameter with a modifier, and multiline parameters.