Repository navigation
fix: discover Tailscale apps and recover stale executable paths - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The settings UI and immediate/scheduled renewal runner share the same locator. Add regression coverage for stale saved paths, preferred valid paths, missing executables, and both macOS Tailscale variants in custom app locations.
Evidence
testImmediateAndDueRenewalsRecoverMissingSavedExecutablefailed withinvalidExecutablewhen the saved path no longer existed, even though another executable was available.After:
swift test --filter 'ConfiguredRenewalRunner.*Tests|TailscaleExecutableLocatorTests'passed all 10 selected tests.Scripts/build-app.shcompleted the release build and strict code signature checks./Applications/Tailscale.app/Contents/MacOS/Tailscalefrom a stale.localizedpath on the affected Mac.Merge Danger
Door: two-way
The code change can be reverted; no persisted configuration schema changes.
Blast Radius: Tailnet
Executable selection is shared by the macOS UI and configured renewal callers (app, agent, CLI, and MCP). Existing executable validation and missing-path errors are preserved.