Skip to content

fix: discover Tailscale apps and recover stale executable paths - #32

Merged
recrack merged 1 commit into
masterfrom
fix/tailscale-executable-discovery
Oct 9, 2026
Merged

recrack merged 1 commit into
masterfrom
fix/tailscale-executable-discovery

Conversation

@recrack

@recrack recrack commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Summary

Tailnet connection check
  use the saved executable if available
  otherwise find a registered Tailscale app's bundle executable
  otherwise try the common app and Homebrew CLI locations

The settings UI and immediate/scheduled renewal runner share the same locator. Add regression coverage for stale saved paths, preferred valid paths, missing executables, and both macOS Tailscale variants in custom app locations.

Evidence

  • Before: testImmediateAndDueRenewalsRecoverMissingSavedExecutable failed with invalidExecutable when the saved path no longer existed, even though another executable was available.
    After: swift test --filter 'ConfiguredRenewalRunner.*Tests|TailscaleExecutableLocatorTests' passed all 10 selected tests.
  • Repository Git hooks passed: public-source checks, Python/Swift tests, iOS Simulator sample builds, Headless tools, Product Hunt assets, public-site tests, and Pages publication tests.
  • Scripts/build-app.sh completed the release build and strict code signature checks.
  • The updated locator found /Applications/Tailscale.app/Contents/MacOS/Tailscale from a stale .localized path on the affected Mac.
  • Physical iPhone installation was not checked because the saved iPhone was offline in Tailscale.

Merge Danger

Door: two-way

The code change can be reverted; no persisted configuration schema changes.

Blast Radius: Tailnet

Executable selection is shared by the macOS UI and configured renewal callers (app, agent, CLI, and MCP). Existing executable validation and missing-path errors are preserved.

@recrack
recrack merged commit 36f5cb4 into master Oct 9, 2026
1 check passed
@recrack
recrack deleted the fix/tailscale-executable-discovery branch October 9, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant