Repository navigation
Document pinned CLI origin and redirect rejection contract - #41
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="DOCUMENTATION-POLICY.md">
<violation number="1" location="DOCUMENTATION-POLICY.md:202">
P3: "Docs owns candidate-guide failures" is ambiguous in this file, where "Docs" also names the separate compatibility host that must not author this guide. Name this repository explicitly so failures route to the right owner.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| immutable CLI #28 merge and runs its existing published-command guard against | ||
| this PR's `content/docs/source/cli.mdx`. Marketing owns candidate-guide failures; | ||
| immutable CLI source revision pinned in that workflow and runs its existing published-command guard against | ||
| this PR's `content/docs/source/cli.mdx`. Docs owns candidate-guide failures; |
There was a problem hiding this comment.
P3: "Docs owns candidate-guide failures" is ambiguous in this file, where "Docs" also names the separate compatibility host that must not author this guide. Name this repository explicitly so failures route to the right owner.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At DOCUMENTATION-POLICY.md, line 202:
<comment>"Docs owns candidate-guide failures" is ambiguous in this file, where "Docs" also names the separate compatibility host that must not author this guide. Name this repository explicitly so failures route to the right owner.</comment>
<file context>
@@ -199,7 +199,7 @@ and keep deployment verification separate from contract checks.
The `cli-guide` job in `.github/workflows/documentation-contract.yml` builds the
immutable CLI source revision pinned in that workflow and runs its existing published-command guard against
-this PR's `content/docs/source/cli.mdx`. Marketing owns candidate-guide failures;
+this PR's `content/docs/source/cli.mdx`. Docs owns candidate-guide failures;
CLI owns command behavior and the guard. The check covers email/song/cost-estimate examples,
`--chat-id` request mapping, and rejection of retired `--room-id` before dispatch.
</file context>
| this PR's `content/docs/source/cli.mdx`. Docs owns candidate-guide failures; | |
| this PR's `content/docs/source/cli.mdx`. This repository owns candidate-guide failures; |
Result
Document the canonical CLI default and GET/POST redirect rejection from exact CLI source 213de5156491e109c6b7243af4c8c17876370d93 (recoupable/cli#34). Explicitly distinguish this source contract from npm publication and the installed client: setting the origin alone does not add redirect protection to old versions.
The existing guide workflow pins that CLI revision and runs its published-command guard, configuration/guide default assertion, and native-fetch loopback redirect tests. Historical CLI guide snapshot remains unchanged. Generated manifest and llms-full are included.
Qualification and sequencing
Independent authored-change review passed. Docs generation/check, 164 tests, types and lint pass; 31 cross-repo CLI guide/config/redirect checks pass with fake credentials only. Local production build and exact-head CI evidence are retained in the coordinator handoff.
Keep this PR draft until CLI34 source is accepted and coordinator chooses publication sequence. No CLI merge, npm publish, installed-artifact claim, replacement client or Context actor request is authorized here. Root owns merges. No broad guide rewrite, API source-pin refresh or credentials/settings change.
Final diagnostic correction: manual non-following fetch rejects 3xx with a fixed safe message, preserves original network failures and existing HTTP/API errors, and exposes no request or redirect details. Independent exact-commit review passed. Docs pins CLI 213de5156491e109c6b7243af4c8c17876370d93; final-head CI is distinct from earlier green results.