This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Correct Context ingest URL and brief purpose docs - #358
Draft
sidneyswift wants to merge 1 commit into
Draft
sidneyswift wants to merge 1 commit into
sidneyswift wants to merge 1 commit into
Conversation
State the real ingest URL behaviour: single YouTube videos validate but the pilot rejects them before any provider call, album URLs belong to ingest_release, and playlists, artist pages and channels are unsupported with a 400 before any provider call. Add company_onboarding to the brief and save_brief purpose enums to match the merged API. Refs recoupable/app#2118 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="api-reference/openapi/context.json">
<violation number="1" location="api-reference/openapi/context.json:71">
P2: `ingest_release` is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| "type": "string", | ||
| "format": "uri", | ||
| "description": "Spotify track URL. Albums, playlists and YouTube ingestion are not enabled in this pilot." | ||
| "description": "Spotify track URL. A single YouTube video URL passes validation but this pilot rejects it before any provider call (only Spotify tracks are enabled). Spotify album URLs, including a single's album page, are rejected here and must be submitted with ingest_release. Playlists, artist pages and channels are unsupported and rejected with 400 before any provider call." |
There was a problem hiding this comment.
P2: ingest_release is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At api-reference/openapi/context.json, line 71:
<comment>`ingest_release` is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.</comment>
<file context>
@@ -68,7 +68,7 @@
"type": "string",
"format": "uri",
- "description": "Spotify track URL. Albums, playlists and YouTube ingestion are not enabled in this pilot."
+ "description": "Spotify track URL. A single YouTube video URL passes validation but this pilot rejects it before any provider call (only Spotify tracks are enabled). Spotify album URLs, including a single's album page, are rejected here and must be submitted with ingest_release. Playlists, artist pages and channels are unsupported and rejected with 400 before any provider call."
},
"idempotency_key": {
</file context>
sidneyswift
marked this pull request as draft
October 10, 2026 20:57
This was referenced Oct 10, 2026
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes two anchored edits to
api-reference/openapi/context.json:The
ingesturldescription. This sentence is owned by the PRs that change the behaviour it describes:parseContextUrl.ingest_video, paired with api#1019.This PR's wording ("YouTube passes validation but this pilot rejects it"; albums "must be submitted with ingest_release") contradicts both and would go stale as soon as either merges. It also points callers to
ingest_release, which this spec does not document, and it does not mention that a YouTube URL gets a generic 409, not a 400.company_onboardingin thebrief/save_briefpurposeenums. recoupable/docs#360 (ctx-2130) and recoupable/docs#365 (ctx-2134) already add this, with descriptions.The ticket's API PR, recoupable/api#1002, adds only internal, unwired contract modules. It changes no public request or response shape, so this ticket needs no docs change of its own.
Refs recoupable/app#2118 (child of epic recoupable/app#2116).
Merge sequencing
Do not merge. If kept open, it would have to merge after #357, #360, #365 and #366, and its edits would then be empty or conflicting. recoupable/api#1002 does not depend on this PR.
Verification
python3 -c "import json;json.load(open('api-reference/openapi/context.json'))"on head1807d0c: parses.grep -c company_onboarding api-reference/openapi/context.json: 2.gh pr difffor docs#357 and Document the ingest_video Context action #366 shows both rewrite the sameingesturlline (hunk@@ -68,7 +68,7 @@).company_onboardingenum values.Out of scope / known gaps
docs.jsonnav changes.🤖 Generated with Claude Code