Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Correct Context ingest URL and brief purpose docs - #358

Draft
sidneyswift wants to merge 1 commit into
mainfrom
claude/ctx-2118-context-contracts
Draft

sidneyswift wants to merge 1 commit into
mainfrom
claude/ctx-2118-context-contracts

Conversation

@sidneyswift

@sidneyswift sidneyswift commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Draft: superseded and redundant; recommend closing without merging. Other open docs PRs already make every edit in this PR, with different wording, and they own the behaviour they describe. Merging this PR as well would conflict with them and contradict them. Sidney decides whether to close it.

Summary

This PR makes two anchored edits to api-reference/openapi/context.json:

  • The ingest url description. This sentence is owned by the PRs that change the behaviour it describes:

    • recoupable/docs#357 (ctx-2126): album routing messages, paired with api#1001, which changes the live parseContextUrl.
    • recoupable/docs#366 (ctx-2131): YouTube moves to ingest_video, paired with api#1019.

    This PR's wording ("YouTube passes validation but this pilot rejects it"; albums "must be submitted with ingest_release") contradicts both and would go stale as soon as either merges. It also points callers to ingest_release, which this spec does not document, and it does not mention that a YouTube URL gets a generic 409, not a 400.

  • company_onboarding in the brief/save_brief purpose enums. recoupable/docs#360 (ctx-2130) and recoupable/docs#365 (ctx-2134) already add this, with descriptions.

The ticket's API PR, recoupable/api#1002, adds only internal, unwired contract modules. It changes no public request or response shape, so this ticket needs no docs change of its own.

Refs recoupable/app#2118 (child of epic recoupable/app#2116).

Merge sequencing

Do not merge. If kept open, it would have to merge after #357, #360, #365 and #366, and its edits would then be empty or conflicting. recoupable/api#1002 does not depend on this PR.

Verification

Out of scope / known gaps

  • No new MDX pages or docs.json nav changes.

🤖 Generated with Claude Code

State the real ingest URL behaviour: single YouTube videos validate but
the pilot rejects them before any provider call, album URLs belong to
ingest_release, and playlists, artist pages and channels are unsupported
with a 400 before any provider call. Add company_onboarding to the brief
and save_brief purpose enums to match the merged API.

Refs recoupable/app#2118

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47bd6530-f8a3-4909-9dbc-a4b8ab64337c

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="api-reference/openapi/context.json">

<violation number="1" location="api-reference/openapi/context.json:71">
P2: `ingest_release` is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

"type": "string",
"format": "uri",
"description": "Spotify track URL. Albums, playlists and YouTube ingestion are not enabled in this pilot."
"description": "Spotify track URL. A single YouTube video URL passes validation but this pilot rejects it before any provider call (only Spotify tracks are enabled). Spotify album URLs, including a single's album page, are rejected here and must be submitted with ingest_release. Playlists, artist pages and channels are unsupported and rejected with 400 before any provider call."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: ingest_release is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At api-reference/openapi/context.json, line 71:

<comment>`ingest_release` is not defined or linked in the published API docs, so readers cannot follow this routing instruction. Link the operation or document its request shape and endpoint.</comment>

<file context>
@@ -68,7 +68,7 @@
                         "type": "string",
                         "format": "uri",
-                        "description": "Spotify track URL. Albums, playlists and YouTube ingestion are not enabled in this pilot."
+                        "description": "Spotify track URL. A single YouTube video URL passes validation but this pilot rejects it before any provider call (only Spotify tracks are enabled). Spotify album URLs, including a single's album page, are rejected here and must be submitted with ingest_release. Playlists, artist pages and channels are unsupported and rejected with 400 before any provider call."
                       },
                       "idempotency_key": {
</file context>

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant