Repository navigation
Qualify retained selection through the existing offline consumer - #143
Draft
sidneyswift wants to merge 5 commits into
Draft
sidneyswift wants to merge 5 commits into
sidneyswift wants to merge 5 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-only retained selection companion: API af21d0037d3cb4b79b837a9c164890537a89a5cb; Database 7e7c871.
Size-limit evaluator refusals return invalid; helper_changed/source_error return error; missing, stale or denied bindings remain unavailable. Every refusal withholds values and diagnostics. comparisonState is a closed comparable/incomplete union with a runtime guard. The README links the private Database proposal and explicitly distinguishes it from a connected live API transport. Supporting types and refusal mapping live in focused modules; the consumer is 93 lines. No successful payload, evaluator, recipe, helper or SQL semantics changed.
Validation: 74 focused API tests (29 consumer, 38 evaluator, 7 math), strict scoped TypeScript and full lint pass. Seven pure compiled transport tests pass, including actual UTF-8 payloads over 512/768 KiB and an actual helper-integrity mismatch in disposable bundle output. Size and integrity regressions have failing-before/passing-after evidence. The 768 KiB witness also exceeds the evidence cap; it does not isolate the envelope cap.
Five actual PostgreSQL17.7 scenarios remain attributed ONLY to original API4ca23de6/Database1185562, using a new Unix-socket-only synthetic cluster with sanitized connection environment and verified process/socket/directory cleanup. These cases were not rerun or relabelled for the successor. No SQL definitions or actual SQL scenario bytes changed.
Pending coordinator review and integration: real authenticated transaction transport, source-family enforcement, max-eight batch concurrency, UI outer negotiation and current authorization across send/replay/persistence/history/text/export/model reads. No production apply/grants/activation, provider execution or merge. Frozen API1290/Database142 unchanged.
Final Cubic P3 addressed: explicit authority/context, kind/recording and source literal types; reference literals checked before projection. Strict TypeScript rejected the old widened reference assignment before the guard was added. Latest 74 API and seven compiled transport tests pass.