Skip to content

Qualify retained selection through the existing offline consumer - #143

Draft
sidneyswift wants to merge 5 commits into
mainfrom
codex/catalog-retained-selection-2207
Draft

sidneyswift wants to merge 5 commits into
mainfrom
codex/catalog-retained-selection-2207

Conversation

@sidneyswift

@sidneyswift sidneyswift commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Source-only retained selection companion: API af21d0037d3cb4b79b837a9c164890537a89a5cb; Database 7e7c871.

Size-limit evaluator refusals return invalid; helper_changed/source_error return error; missing, stale or denied bindings remain unavailable. Every refusal withholds values and diagnostics. comparisonState is a closed comparable/incomplete union with a runtime guard. The README links the private Database proposal and explicitly distinguishes it from a connected live API transport. Supporting types and refusal mapping live in focused modules; the consumer is 93 lines. No successful payload, evaluator, recipe, helper or SQL semantics changed.

Validation: 74 focused API tests (29 consumer, 38 evaluator, 7 math), strict scoped TypeScript and full lint pass. Seven pure compiled transport tests pass, including actual UTF-8 payloads over 512/768 KiB and an actual helper-integrity mismatch in disposable bundle output. Size and integrity regressions have failing-before/passing-after evidence. The 768 KiB witness also exceeds the evidence cap; it does not isolate the envelope cap.

Five actual PostgreSQL17.7 scenarios remain attributed ONLY to original API4ca23de6/Database1185562, using a new Unix-socket-only synthetic cluster with sanitized connection environment and verified process/socket/directory cleanup. These cases were not rerun or relabelled for the successor. No SQL definitions or actual SQL scenario bytes changed.

Pending coordinator review and integration: real authenticated transaction transport, source-family enforcement, max-eight batch concurrency, UI outer negotiation and current authorization across send/replay/persistence/history/text/export/model reads. No production apply/grants/activation, provider execution or merge. Frozen API1290/Database142 unchanged.

Final Cubic P3 addressed: explicit authority/context, kind/recording and source literal types; reference literals checked before projection. Strict TypeScript rejected the old widened reference assignment before the guard was added. Latest 74 API and seven compiled transport tests pass.

@supabase

supabase Bot commented Nov 19, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project godremdqwajrwazhbrue because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant