Skip to content

Qualify offline retained evidence writer and atomic receipts (#2207) - #129

Merged
sswiftdrtv merged 1 commit into
mainfrom
codex/stream-retention-writer-2207
Oct 27, 2026
Merged

sswiftdrtv merged 1 commit into
mainfrom
codex/stream-retention-writer-2207

Conversation

@sswiftdrtv

@sswiftdrtv sswiftdrtv commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The adopted evidence read proof did not implement retention. This adds an executable, default-denied offline writer using existing Context sources, versions, attempts, results, lineage and documents. Retry identity and exact receipts live in existing attempt/result fields; no parallel receipt store or observation mirror is added.

Canonical protocol and writer inventory.

Shared scope locks, document CAS and adopted readback qualify first creation, concurrent same-key replay and cross-catalog replacement. Invalid saves and late receipt failures roll back all tentative rows and document changes. Customer assertions, withdrawal history, provider conflicts and retained retrieval timestamps are preserved. Logical row/history/byte budgets refuse overflow without truncation.

45 tests pass in fresh PostgreSQL 15 and 17 CI at head 703a8d9: all 25 adopted read regressions plus 20 executable writer tests. Independent exact-head source review also passes. Tests include actual stream commit corrections, competing withdrawal/membership/commit locks, exact replay/reconciliation and injected final-receipt failure rollback.

Everything remains outside migrations. No service grants, runtime call sites, ingestion, provider/customer calls or derived-field authority. Atomicity is qualified only for participating operations; privileged generic/direct writers and hard execution deadlines remain deployment gates. Root owns merge and activation approval.

@supabase

supabase Bot commented Oct 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project godremdqwajrwazhbrue because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f1a8fcf-0d30-465d-8014-ccc7ea639866
Commits

Reviewing files that changed from the base of the PR and between 7160086 and 703a8d9.

Files selected for processing: 6
  • .github/workflows/stream-binding-proposal.yml
  • proposals/stream-evidence-binding-2207/PROTOCOL.md
  • proposals/stream-evidence-binding-2207/proposal.sql
  • proposals/stream-retention-writer-2207/PROTOCOL.md
  • proposals/stream-retention-writer-2207/test_writer.py
  • proposals/stream-retention-writer-2207/writer.sql
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T16:33:01.205422Z 703a8d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sswiftdrtv
sswiftdrtv merged commit cd5b46d into main Oct 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants