Repository navigation
Qualify offline retained evidence writer and atomic receipts (#2207) - #129
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The adopted evidence read proof did not implement retention. This adds an executable, default-denied offline writer using existing Context sources, versions, attempts, results, lineage and documents. Retry identity and exact receipts live in existing attempt/result fields; no parallel receipt store or observation mirror is added.
Canonical protocol and writer inventory.
Shared scope locks, document CAS and adopted readback qualify first creation, concurrent same-key replay and cross-catalog replacement. Invalid saves and late receipt failures roll back all tentative rows and document changes. Customer assertions, withdrawal history, provider conflicts and retained retrieval timestamps are preserved. Logical row/history/byte budgets refuse overflow without truncation.
45 tests pass in fresh PostgreSQL 15 and 17 CI at head 703a8d9: all 25 adopted read regressions plus 20 executable writer tests. Independent exact-head source review also passes. Tests include actual stream commit corrections, competing withdrawal/membership/commit locks, exact replay/reconciliation and injected final-receipt failure rollback.
Everything remains outside migrations. No service grants, runtime call sites, ingestion, provider/customer calls or derived-field authority. Atomicity is qualified only for participating operations; privileged generic/direct writers and hard execution deadlines remain deployment gates. Root owns merge and activation approval.