Repository navigation
fix: Align OAuth MCP annotations with tool behavior - #1238
Merged
Merged
Conversation
Require explicit behavioral hints, cover full and limited catalogs, document classifications, and disable preview deployments for this review branch.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make OAuth MCP annotations describe actual tool behavior rather than defaulting every tool to open-world or inferring destructiveness from a few names.
This changes metadata and descriptions, not handlers, schemas, authorization, scopes or business behavior.
Tests
pnpm typecheck:mcp-oauthand final direct OAuth TypeScript check passed.pnpm exec tsc --noEmit --project tsconfig.build.json,pnpm typecheck:response-contracts, andpnpm typecheck:release-format.pnpm lint:check, changed TypeScript formatting andgit diff --checkpassed.Draft / release limitations
This is ready for code review, not an assertion that the deployed plugin is qualified for approval.
b371f5ed2f2cda150de6156d5a3d6b0c5f7afb21. Database behavior was traced through all relevant migration definitions atebdb549d0b719a95ee7105bb9146c077841411e6; deployed database state is not verified.tools/listfrom the exact intended review endpoint in full and limited OAuth modes against the inventory. Confirm the pack-settlement migration behavior.search_webpreference language and role/message-array research input also deserve a separate submission-metadata/data-minimization review.Deployment guard
vercel.jsondisables automatic deployment only for this exact branch,fix/mcp-oauth-behavior-annotations, using Vercel's branch-specific setting. Existing cron settings and every other branch's deployment behavior are unchanged. The exact guard and preservation of all prior config were checked locally. GitHub CI remains enabled. Do not remove the guard, merge, deploy or resubmit without the separate release decision.Parallel PRs
No existing annotation-repair PR was found before starting publication. Two open PRs touch adjacent code:
Coordinator disposition: this source candidate is superseded by merged #1252, which preserves its history and adds the qualified review/composition fixes. Closing this PR avoids competing source candidates; its branch/history remain preserved. Owning-epic authenticated/native/provider/database and business acceptance remain open as separately recorded; source merge does not close those gates.