Repository navigation
Clarify release pack charge accounting without changing prices - #1212
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pre-merge checks:
|
| Check name | Status | Explanation |
|---|---|---|
| Solid & Clean Code | Reviewed the PR's own changes, which are the diff from released Catalog main 486d32e to head 28f8601 (8 files, +160/-4). Primary author is sidneyswift (GitHub, verified). Production changes are smal… |
Full details: Solid & Clean Code
-
Explanation
Reviewed the PR's own changes, which are the diff from released Catalog main 486d32e to head 28f8601 (8 files, +160/-4). Primary author is sidneyswift (GitHub, verified). Production changes are small and focused: -
lib/const.ts: adds onepackCostAccountingconstant object. The accounting labels are defined once, which follows the DRY and configuration-object guidance. -buildReleasePackQuote.ts: adds onecost_accounting: { ...packCostAccounting }line to the returned object. No new function. -readPackSnapshot.ts: wrapsjobwith aquotespread that addscost_accounting. This adds about 5 lines. The function was already about 50 lines before this PR, so it exceeds the 20-line guideline. The PR worsens that length only slightly, and the added logic is a single expression. -packTypes.ts: type-only change that makes the legacy field optional. No new function. -lib/mcp/tools/packs/index.ts: updates one tool description string. -published-docs.json: fixture hash update. No new function was added to an existing file, so the file-function name rule is not triggered. The new test files contain only test cases. Minor observations, not failures: - Theaccountingliteral inpackCostAccounting.test.tsand the label literals inpackFirstUse.test.tsrepeat the constant values. The tests assert the contract explicitly, so this is acceptable. - The same inline spread is used in two production files. This is a small repetition. -readPackSnapshotremains a long function. Its length predates this PR, and the PR only adds a few lines. No explicit failure condition of the SOLID and Clean Code check is established by the changed code.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Add explanatory quote.cost_accounting labels to new Release Pack quotes and legacy readback. Customer charges remain distinct from unmeasured provider expense and unfunded concepts, contingency and refinements. Numeric prices, configuration, fingerprints, stored approvals, retry authorization, provider execution/recovery and saved progress are unchanged.
Exact reviewed head 28f8601, tree da343a971eb696ab8fed5ce9bd7edbdf0c4ed115, normally integrates released Catalog main 486d32e. Incoming Catalog behavior is preserved. Combined published fixture SHA256 7af66d00e0b6fcb7e5a2f27124d173273c973badd670430c0084809f21719458 matches the actual Docs producer.
Validation: 237 affected tests; production, pack and response-contract types; lint/format; exact-head full CI passed. Independent exact-source review found no blocking findings. Cubic skipped AI review for the merge commit; its success is not independent approval.
Docs30 merged first as 82935171f7846e6a3f867bdcb5cc505639ebd8be after exact-source paired/inventory checks, independent source review, fresh browser guide/read/export/fixed false-zero/null acceptance, supported static-file download and independent final receipt review. The downloaded bytes exactly match the existing serializer and full parsed JSON equals authored source. Historical failed download and old paired mismatch remain historical outcomes, resolved for this bounded current release by later evidence.
These checks do not establish authenticated customer workflows, measured provider expenses, funded creative execution, production data changes or postmerge deployment acceptance. No provider/customer/database/spend/access/manual deployment action was performed.