Repository navigation
Sync published trailing-delete description from docs-site - #1160
Conversation
The docs review (docs-site#5) shortens the DELETE
/api/chats/{id}/messages/trailing operation description to three
sentences. This copies the regenerated record, so docs-site's
build-contract-examples --check matches once the inventory pins this merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update the published contract fixture lib/contracts/fixtures/published-docs.json |
The chatTrailingDelete description now states that deletion is ordered by created_at and id, concurrent edit or resend is unsupported, and an active workflow run returns 409. It also notes that a successful 200 may affect zero rows and advises refreshing history after a transport failure. The fixture updates the recorded SHA-256 for research.json. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related issues
- recoupable/mono issue 360: The fixture update is a concrete example of keeping a published API record aligned with documentation checks.
- recoupable/mono issue 320: The PR revises the published description for
DELETE /api/chats/{id}/messages/trailing. - recoupable/mono issue 319: The updated API-reference record is part of the published documentation workflow.
Suggested reviewers: sidneyswift
Merge Risk: 
Minimal · up to 06cda
-
This fixture-only update has no identified merge-blocking impact.
Pre-merge checks: 
3
-
Full details: Solid & Clean Code
-
Explanation
PASS. The pull request changes only the generated JSON fixture
lib/contracts/fixtures/published-docs.json. It adds no classes, functions, control flow, abstractions, or duplicated logic. The JSON remains valid, and the changed description is a simple three-sentence data value.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A hash takes a refreshed place,
A contract gets a shorter face.
The sort keys set the order right,
A 409 marks workflow flight.
History refreshes after a lost reply.
Comment @coderabbitai help to get the list of available commands.
Fixture-only companion to docs-site#5 (tracker: app#2352).
Review feedback on docs-site#5: operation descriptions should be at most 4 sentences, ideally 2-3. The
DELETE /api/chats/{id}/messages/trailingdescription was 13. docs-site#5 rewrites it to three:The dropped detail (legacy memories untouched, auth, ownership, timestamp tie-break) is still stated by the operation's parameters, security and per-status response descriptions.
lib/contracts/fixtures/published-docs.jsonholds a copy of the published record, so this PR updates it withpython3 scripts/build-contract-examples.py --api <this checkout>from docs-site#5. The diff is two lines:chatTrailingDelete.descriptionand theresearch.jsonsource hash. No runtime code changes.Merge order: this PR first, then docs-site#5 re-pins
operation-inventory.jsonto this merge commit (docs-site CI checks the fixture at the pinned API commit).Checks:
pnpm exec vitest run lib/contracts→ 29 files, 308 tests pass.🤖 Generated with Claude Code
Summary by CodeRabbit