Skip to content

test: bind published Slack author contracts to admin routes - #1094

Merged
sidneyswift merged 1 commit into
mainfrom
codex/slack-author-docs-contract
Oct 21, 2026
Merged

sidneyswift merged 1 commit into
mainfrom
codex/slack-author-docs-contract

Conversation

@sidneyswift

@sidneyswift sidneyswift commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The released coding Slack analytics now accept an author filter and provide a distinct-author options endpoint, but the published contract does not describe them. Freeze the maintained descriptions, request example and resolved response schemas in the shared fixture; add a provider-free contract test that invokes the real GET/query/authentication code.

Runtime API #1093 is actual eb342015246823cd110af7935bcf4737f7f0f106; its whole tree equals accepted ab0169e85b84fa3304f95caad2f69b3242399453. This companion changes only contract tests, their fixture and verification guidance, with no runtime handler, collector, authentication or charge change. All prior fixture sections remain exact apart from the accounts source hash and new adminCodingSlack section. The fixture in Marketing #220 is byte-identical. Its contributor-guidance follow-up and actual source-pin refresh remain separate.

The new test first failed 12 cases because the old published fixture lacked this contract. After regeneration, 240 focused contract/admin-Slack tests across 29 files pass, response-contract typecheck, full lint, changed-file formatting and whitespace pass. Checks cover copied filter syntax, trimmed/omitted/unknown IDs, totals after filtering, distinct first-profile author options/empty response, both 401 envelopes, admin403, query400 and generic500. Credential/admin lookup and Slack collection are mocked; unexpected network/database calls are fenced off.

Preserve admin-only access and existing collector/history/retention/pagination/partial-failure limits. The options route performs an all-period scan when explicitly called; this is not a complete all-time directory, free cached metadata or reduced collection work. No automatic caller/UI/poller/scheduled action/send, production access/latency/quota proof, provider/customer/billing/database operation or original-ticket closure is introduced.

Based on actual API #1093 and preserves the tool-count fixture from #1092. Marketing base is actual #219 548ed38b9f72a5689ca63f7c9feb87c1744408f4; retained tool-count Docs #400 remains a separate ordered publication. Independent Spec and Standards reviews of this API candidate report zero findings at cdb8ee85695eca3efecd7ba303803747fc2600b4. Current format/lint/compatibility/test/preview and CodeRabbit checks pass, with no unresolved review threads. Full TypeScript retains 211 byte-identical baseline diagnostics and no new test diagnostics; it is not clean. Ready for Records/coordinator acceptance and guarded merge. After actual fixture merge, Marketing refreshes its API pin, passes checks/build/review, then retained Docs follows actual Marketing. Records/coordinator owns guarded merges; Docs does not merge. Existing API #338 and held gates remain unchanged.


Summary by cubic

The published coding Slack contract now documents the author filter and distinct-author options endpoint that the runtime already supports. Adds contract tests that run the real admin GET routes against a frozen fixture, with Slack collection and admin lookup mocked.

  • Freezes request declarations, examples, and resolved response schemas for both admin endpoints in published-docs.json.
  • Covers filter trimming and case-sensitivity, omitted/unknown IDs, filtered totals, distinct first-profile options, empty responses, and the 400/401/403/500 envelopes.
  • No runtime handler, collector, authentication, or charge changes; existing admin-only access and collection limits are preserved.

Written for commit cdb8ee8. Summary will update on new commits.

View guided diff Turn on auto-fix

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Oct 21, 2026 10:02pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: recoupable/api/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4e88edb0-93d8-4e24-96aa-957bec412158
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sidneyswift
sidneyswift marked this pull request as ready for review October 21, 2026 22:09
@sidneyswift
sidneyswift merged commit 1d2109f into main Oct 21, 2026
7 checks passed

This branch was successfully deployed

1 active deployment
Preview — cdb8ee85 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant