Repository navigation
fuzz: keep compact follow inside Core's mock clock - #972
Merged
Merged
Conversation
The nightly compact job setmocktime's bitcoind to regtest genesis, then stamped headers up to genesis plus about three hours. Core rejected those as time-too-new while the hub, on the wall clock, accepted them. Fold the stamp into the two-hour window, pin the follow accept to the same clock, and put Core's submitblock reason on the split panic. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setmocktimeis regtest genesis.time-too-newon both sides.submitblockreason in the compact follow split panic.Overnight
cmpct_differentialpanickedours=true core=falseon a coinbase-only block 961 seconds past that cap. The hub uses the wall clock, so a 2011 stamp was not too new.Test plan
cargo test --manifest-path fuzz/Cargo.toml --lib(the three new pins failed first)test/qc(workspace suite is not run locally on this PR)Made with Cursor