Repository navigation
store: keep block filters and sp tweaks on the cold volume - #970
Merged
Merged
Conversation
--datadir-cold already holds seqsigwit, txstat, and input. Optional blockfilter and sp_tweaks indexes are created there too. A split open refuses those directories when they are still on the hot store. --prune-seqsigwit still only drops historical seqsigwit.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--datadir-coldis the append-only volume. It already heldseqsigwit,txstat, andinput. Optionalblockfilterandsp_tweaksindexes are created there too.--prune-seqsigwitis unchanged: it drops historical seqsigwit below tip−288 and keeps the 288-height window on the hot store. It does not delete txstat, input, filters, or tweaks.Operator docs, CLI help, the
mvrecipe, andsize_on_diskwording match that split. No schema bump.Test plan
cargo test -p rbitcoin-store --lib split_refuses_cargo test -p rbitcoin-query --lib split_store_puts_blockfilternode_cli_and_surface_smoke(txstat and input land on the cold store)ci-os-smoke.sh, nixos-module-evalqc,test,windows,macos,coverage)