Repository navigation
docs: clock inventory for #821 step 1 (100 sites, 886463ef) - #825
Closed
Hero-Gamer wants to merge 3 commits into
Closed
Hero-Gamer wants to merge 3 commits into
Hero-Gamer wants to merge 3 commits into
Conversation
HEAD: 886463e Merge reardencode#823 (latest master) - clock.rs:44 root wall source = LEAVE - tx_relay.rs:928 manual mock check = node-time MIGRATE to NodeClock - tx_relay.rs:3753 tmp uniqueness = log/perf LEAVE - bulk_io 10, bdz 5, etc = log/perf LEAVE - peers.rs 3, service.rs 3, peer.rs 4 = node-time MIGRATE for Steps 2/3 No prod change. Tracks reardencode#688 item 2.1, part of reardencode#821, follows reardencode#740
- peers.rs:1249 AtomicU64 0=wall, Acquire/Release - tx_relay.rs:625 AtomicU64 0=wall, Relaxed/Relaxed - chain.rs: hub.clock.set_mock() third clock - split-brain enables INV freeze and peer timeout bypass No prod change, adversarial review for reardencode#821
…6463e repro: rg -n SystemTime::now crates/ --type rust -g '!*tests*' | cut -d: -f1,2 = 100/100 match
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of #821 - inventory only, no prod change.
HEAD: 886463e Merge #823 - latest master Sep 27, includes #822/#813/#773/#769/#746
Command: rg -n "SystemTime::now()" crates/ --type rust -g '!tests' = 100 sites
Verified: rg | cut -d: -f1,2 vs docs table = 100/100 match, comm -23 empty, comm -13 empty after fix 923->928, cargo fmt --all --check=0, no trailing WS, 120 lines total
Breakdown (100 rows):
Adversarial findings for Step 2/3:
All LEAVE marked log/perf per OPERATOR.md #688 item 2.1.
Unblocks Step 2 PeerManager NodeClock injection and Step 3 TxRelay shared NodeClock.
Ref #740 unified-clock-api, part of #821, tracks #688 item 2.1