Skip to content

Upgrade all the rubies - use 3.3 by default#106

Merged
djmattyg007 merged 2 commits into
realestate-com-au:mainfrom
tigris:ruby-upgrades
Apr 23, 2024
Merged

Upgrade all the rubies - use 3.3 by default#106
djmattyg007 merged 2 commits into
realestate-com-au:mainfrom
tigris:ruby-upgrades

Conversation

@tigris

@tigris tigris commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@djmattyg007 djmattyg007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes a lot of sense 👍 Should we remove support for Ruby 2.7 while we're here?

@tigris

tigris commented Apr 23, 2024

Copy link
Copy Markdown
Contributor Author

Should we remove support for Ruby 2.7 while we're here?

We could do that. Ruby 3.0 is also EOL as of 3 weeks ago, would you like that removed also?

@djmattyg007

Copy link
Copy Markdown
Contributor

Yep, let's do it. It won't magically remove old versions that do claim support for it.

@djmattyg007 djmattyg007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@djmattyg007 djmattyg007 merged commit 7cef2f7 into realestate-com-au:main Apr 23, 2024
@rea-jonpad

Copy link
Copy Markdown

This also makes #101 redundant, and can be closed

@tigris

tigris commented Jul 28, 2024

Copy link
Copy Markdown
Contributor Author

Any chance we can get a release?

I do believe there is a stackup-ci pipeline you can just hit "new build" on 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants