Repository navigation
[REA-6855] Read the runtime.step_results block from the manifest - #236
Merged
Merged
Conversation
This was referenced Oct 3, 2026
This was referenced Oct 3, 2026
Contributor
Author
This was referenced Oct 3, 2026
tempusfrangit
approved these changes
Oct 3, 2026
tempusfrangit
left a comment
Contributor
There was a problem hiding this comment.
Approved with a nonblocking documentation follow-up: please move the runtime.step_results README documentation from #239 into this PR so it lands with the manifest surface, as noted in the existing inline comment. The configuration parsing looks sound.
Dere-Wah
force-pushed
the
dere/rea-6854-close-the-session-at-steps
branch
from
October 4, 2026 16:39
c0f4bc9 to
8c05792
Compare
Dere-Wah
force-pushed
the
dere/rea-6855-step-results-manifest-block
branch
from
October 4, 2026 16:39
498bd52 to
3e06488
Compare
Contributor
Author
|
@tempusfrangit done in fcfd87c: the |
Dere-Wah
force-pushed
the
dere/rea-6855-step-results-manifest-block
branch
from
October 4, 2026 18:28
fcfd87c to
9036aff
Compare
Dere-Wah
force-pushed
the
dere/rea-6854-close-the-session-at-steps
branch
from
October 4, 2026 18:28
8c05792 to
b00b1d3
Compare
Dere-Wah
force-pushed
the
dere/rea-6855-step-results-manifest-block
branch
from
October 4, 2026 23:47
9036aff to
966a3b6
Compare
Dere-Wah
force-pushed
the
dere/rea-6854-close-the-session-at-steps
branch
from
October 4, 2026 23:47
b00b1d3 to
686e937
Compare
ggoldens
approved these changes
Oct 5, 2026
Dere-Wah
force-pushed
the
dere/rea-6854-close-the-session-at-steps
branch
from
October 5, 2026 17:58
686e937 to
7aaeb4d
Compare
Dere-Wah
force-pushed
the
dere/rea-6855-step-results-manifest-block
branch
from
October 5, 2026 17:58
966a3b6 to
61c2179
Compare
Contributor
Author
Dere-Wah
changed the base branch from
dere/rea-6854-close-the-session-at-steps
to
graphite-base/236
October 5, 2026 18:20
Whether each finished step is kept as a folder of files is the model's
choice, made in its reactor.yaml next to runtime.recording, not a session
option a client can switch. The block turns saving on and sets how the
step's output is encoded:
runtime:
step_results:
enabled: true
video: {codec: h264, preset: veryfast, crf: 23}
audio: {codec: aac, bitrate_kbps: 128}
queue: 8
It names no tracks: every track of a step's output is kept as its own
stream. queue bounds how many steps may wait to be saved, so a model that
steps faster than its steps encode never waits on saving; a queue below 1
fails the load. A missing or malformed block leaves step results off at their
defaults, and unknown keys are ignored, as for the recording block. The
session descriptor reports step_results.enabled beside recording. Nothing
is saved yet; the store and the routes follow.
Signed-off-by: Dere-Wah <derexcontact@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…saved The runtime.step_results block is a model-authoring surface, so the README now describes it where the manifest is introduced: how to turn it on, what a saved folder holds, what queue bounds, and that each step is its own encode. The session descriptor stops reporting step_results here. Nothing saves a step until the store lands, so a descriptor that said enabled: true would promise folders the runtime never writes; the field returns with the store. Signed-off-by: Dere-Wah <derexcontact@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Dere-Wah
force-pushed
the
dere/rea-6855-step-results-manifest-block
branch
from
October 5, 2026 18:23
61c2179 to
4d6da06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Whether each finished step is kept as a folder of files is the model's choice, the same way recording is: it decides what is worth keeping and how to encode it. So it belongs in the model's
reactor.yaml, next toruntime.recording, and not in a session option a client could switch.What Changed
The manifest gains a
runtime.step_resultsblock:It names no tracks: every track of a step's output is kept as its own stream.
queuebounds how many steps may wait to be saved, so a model that steps faster than its steps encode never waits on saving; aqueuebelow 1 fails the load, because an unbounded queue is what that value would otherwise mean. A missing or malformed block leaves step results off at their defaults, and unknown keys are ignored, as for the recording block.The block parses into a
StepResultsConfigonRuntimeConfig, and the README documents it where the manifest is introduced, so the authoring surface lands with its documentation. Nothing is saved yet: the writer, the store, and the routes follow in the next PRs, and the session descriptor reports"step_results"only from #238, where steps are saved, so it never promises folders the runtime does not write.