Skip to content

[REA-6855] Read the runtime.step_results block from the manifest - #236

Merged
Dere-Wah merged 2 commits into
mainfrom
dere/rea-6855-step-results-manifest-block
Oct 5, 2026
Merged

Dere-Wah merged 2 commits into
mainfrom
dere/rea-6855-step-results-manifest-block

Conversation

@Dere-Wah

@Dere-Wah Dere-Wah commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

Whether each finished step is kept as a folder of files is the model's choice, the same way recording is: it decides what is worth keeping and how to encode it. So it belongs in the model's reactor.yaml, next to runtime.recording, and not in a session option a client could switch.

What Changed

The manifest gains a runtime.step_results block:

runtime:
  step_results:
    enabled: true
    video: {codec: h264, preset: veryfast, crf: 23}   # or codec: h265
    audio: {codec: aac, bitrate_kbps: 128}
    queue: 8

It names no tracks: every track of a step's output is kept as its own stream. queue bounds how many steps may wait to be saved, so a model that steps faster than its steps encode never waits on saving; a queue below 1 fails the load, because an unbounded queue is what that value would otherwise mean. A missing or malformed block leaves step results off at their defaults, and unknown keys are ignored, as for the recording block.

The block parses into a StepResultsConfig on RuntimeConfig, and the README documents it where the manifest is introduced, so the authoring surface lands with its documentation. Nothing is saved yet: the writer, the store, and the routes follow in the next PRs, and the session descriptor reports "step_results" only from #238, where steps are saved, so it never promises folders the runtime does not write.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

[codex-review] - [P1] runner.py: Descriptor advertises enabled retention although no results are saved.

  • [P2] manifest.py: New authoring surface is missing the required README documentation.

Scope: full (c0f4bc9..498bd52).

View workflow run.

Comment thread src/reactor_runtime/runner/runner.py Outdated
Comment thread src/reactor_runtime/manifest.py

@tempusfrangit tempusfrangit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nonblocking documentation follow-up: please move the runtime.step_results README documentation from #239 into this PR so it lands with the manifest surface, as noted in the existing inline comment. The configuration parsing looks sound.

@Dere-Wah
Dere-Wah force-pushed the dere/rea-6854-close-the-session-at-steps branch from c0f4bc9 to 8c05792 Compare October 4, 2026 16:39
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6855-step-results-manifest-block branch from 498bd52 to 3e06488 Compare October 4, 2026 16:39
@Dere-Wah

Dere-Wah commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@tempusfrangit done in fcfd87c: the runtime.step_results README documentation now lands here with the manifest surface (#239 keeps only the routes), and the descriptor no longer advertises step_results until #238 saves steps.

@Dere-Wah
Dere-Wah force-pushed the dere/rea-6855-step-results-manifest-block branch from fcfd87c to 9036aff Compare October 4, 2026 18:28
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6854-close-the-session-at-steps branch from 8c05792 to b00b1d3 Compare October 4, 2026 18:28
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6855-step-results-manifest-block branch from 9036aff to 966a3b6 Compare October 4, 2026 23:47
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6854-close-the-session-at-steps branch from b00b1d3 to 686e937 Compare October 4, 2026 23:47
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6854-close-the-session-at-steps branch from 686e937 to 7aaeb4d Compare October 5, 2026 17:58
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6855-step-results-manifest-block branch from 966a3b6 to 61c2179 Compare October 5, 2026 17:58

Dere-Wah commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Oct 5, 6:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 5, 6:24 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 5, 6:25 PM UTC: @Dere-Wah merged this pull request with Graphite.

@Dere-Wah
Dere-Wah changed the base branch from dere/rea-6854-close-the-session-at-steps to graphite-base/236 October 5, 2026 18:20
@Dere-Wah
Dere-Wah changed the base branch from graphite-base/236 to main October 5, 2026 18:22
Dere-Wah and others added 2 commits October 5, 2026 18:23
Whether each finished step is kept as a folder of files is the model's
choice, made in its reactor.yaml next to runtime.recording, not a session
option a client can switch. The block turns saving on and sets how the
step's output is encoded:

    runtime:
      step_results:
        enabled: true
        video: {codec: h264, preset: veryfast, crf: 23}
        audio: {codec: aac, bitrate_kbps: 128}
        queue: 8

It names no tracks: every track of a step's output is kept as its own
stream. queue bounds how many steps may wait to be saved, so a model that
steps faster than its steps encode never waits on saving; a queue below 1
fails the load. A missing or malformed block leaves step results off at their
defaults, and unknown keys are ignored, as for the recording block. The
session descriptor reports step_results.enabled beside recording. Nothing
is saved yet; the store and the routes follow.

Signed-off-by: Dere-Wah <derexcontact@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…saved

The runtime.step_results block is a model-authoring surface, so the
README now describes it where the manifest is introduced: how to turn it
on, what a saved folder holds, what queue bounds, and that each step is
its own encode.

The session descriptor stops reporting step_results here. Nothing saves
a step until the store lands, so a descriptor that said enabled: true
would promise folders the runtime never writes; the field returns with
the store.

Signed-off-by: Dere-Wah <derexcontact@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Dere-Wah
Dere-Wah force-pushed the dere/rea-6855-step-results-manifest-block branch from 61c2179 to 4d6da06 Compare October 5, 2026 18:23
@Dere-Wah
Dere-Wah merged commit 3a18b6b into main Oct 5, 2026
10 checks passed
@Dere-Wah
Dere-Wah deleted the dere/rea-6855-step-results-manifest-block branch October 5, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants