This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Check for options change in ComponentWillReceiveProps#180
Open
jgliner wants to merge 1 commit intoreactjs:chartjs-v2from
Open
Check for options change in ComponentWillReceiveProps#180jgliner wants to merge 1 commit intoreactjs:chartjs-v2from
jgliner wants to merge 1 commit intoreactjs:chartjs-v2from
Conversation
Collaborator
|
hi @jgliner, would it possible to redraw when you update I want to make sure we're minimizing regressions as we currently do not have any tests (will add some soon). Please let me know if that works for you. Thanks |
Collaborator
|
Hi @jgliner, sorry I mis-understood. I see what you are talking about. If this is the case, I prefer that we use react's core utility for this case. Please see below for example. var shallowEqual = require('fbjs/lib/shallowEqual');
var optsChange = !shallowEqual(nextProps.options, this.props.options);Please update PR when you get a chance. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
optionswon't update along with the chart if new props are passed. This is especially an issue when updating charts dynamically (e.g. changing theyAxeslabel from a dropdown menu). There may be a slightly more elegant way to check for changes in user-defined options, but this check should not negatively affect performance.