This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Add support for HorizontalBarChart and fix handling of chartType string#133
Open
jscinoz wants to merge 8 commits intoreactjs:chartjs-v2from
Open
Add support for HorizontalBarChart and fix handling of chartType string#133jscinoz wants to merge 8 commits intoreactjs:chartjs-v2from
jscinoz wants to merge 8 commits intoreactjs:chartjs-v2from
Conversation
Collaborator
|
+1 - This would also close #116 and maybe a few others |
|
+1 |
|
Hi, I want to try this branch. Where can I access it? I need to test the horizontal bar charts for a project. |
|
Could you test and merge this branch? It's very useful since we don't want to use separate library for single horizontal chart. |
|
👍 |
Collaborator
|
@jscinoz this PR needs to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new horizontalBar chart type in upstream Chart.js, and uses change-case to convert react-chartjs' PascalCase chartType values to the expected camelCase values.