This repository was archived by the owner on Jul 19, 2019. It is now read-only.
enable line chart to change it colors dynamically#101
Open
5c077yP wants to merge 1 commit intoreactjs:masterfrom
blogfoster:master
Open
enable line chart to change it colors dynamically#1015c077yP wants to merge 1 commit intoreactjs:masterfrom blogfoster:master
5c077yP wants to merge 1 commit intoreactjs:masterfrom
blogfoster:master
Conversation
Author
|
Hey any plans on looking at this ? |
Member
|
April 11, yikes! I just tested this and it works. However, I would much prefer a whitelist of things that are known to not cause trouble rather than blacklisting "data". |
Collaborator
|
@5c077yP this PR needs to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
we recently introduced this lib into our own app and i noticed that one cannot change the line chart color dynamically. Looking at the code shows that only datapoints are updated, but updating other properties from the dataset can also be updated (i tested that locally).
So here the PR, this enables the Line Chart to update it's colors dynamically without setting the
redrawattribute.