Skip to content

Conversation

@shawncrawley
Copy link

Description

My attempt at refactoring to align with ReactPy v2.0.0. This depends upon the refactors that were also made to reactpy-router to align with ReactPy v2.0.0 (see PR for that here).

There are a few remaining fixes/updates that I haven't been able to figure out yet. These are the related tests that fail when I run them locally:

  • tests\test_app\tests/test_components.py:230 ComponentTests.test_component_use_user_data
  • tests\test_app\tests/test_components.py:286 ComponentTests.test_component_use_user_data_with_default
  • tests\test_app\tests/test_components.py:685 ComponentTests.test_form_basic
  • tests\test_app\tests/test_components.py:779 ComponentTests.test_form_bootstrap
  • tests\test_app\tests/test_components.py:817 ComponentTests.test_form_orm_model
  • tests\test_app\tests/test_components.py:565 ComponentTests.test_pyscript_0_hello_world
  • tests\test_app\tests/test_components.py:575 ComponentTests.test_pyscript_1_multifile

The first two are related to open discussion here. As for the rest, I still have no idea what the problem is after digging for hours.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@shawncrawley shawncrawley requested a review from a team as a code owner February 12, 2026 18:32
from reactpy import Vdom

pyscript = make_vdom_constructor("py-script")
pyscript = Vdom("py-script")
Copy link
Contributor

@Archmonger Archmonger Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed. An update to pyscript has deprecated the py-script HTML tag. The correct syntax now uses a normal script tag.

For example: <script type='py'>{EXAMPLE_CONTENTS}</script>.

See pyscript_component_html in reactpy core as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants