Improve native createTheme token normalization#489
Closed
yaminyassin wants to merge 1 commit into
Closed
Conversation
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
5b42fa9 to
6ab4a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace regex in native createTheme token normalization
Summary
Native
css.createThemeno longer uses a regex to stripvar(--and)from tokens returned bycss.defineVars. The code now checks for the generated prefix/suffix and slices the token name directly.This relies on the existing
createThemecontract: the first argument is the return value ofdefineVars. NativedefineVarsemits tokens asvar(--${name}).Test Plan
npm inpm run flownpm testnpm run perf --workspace benchmarksnpm run size --workspace benchmarks