Skip to content

Avoid red iOS E2E checks when a retry succeeds - #59646

Draft
cortinico wants to merge 1 commit into
mainfrom
codex/ci-ios-retry-signals
Draft

cortinico wants to merge 1 commit into
mainfrom
codex/ci-ios-retry-signals

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:

The initial iOS TemplateApp Release build on 60e7809 failed while resolving @babel/parser but passed on a fresh-runner retry. #58942 correctly triggers that retry; the initial failed build still appears red on the commit.

Record each Debug/Release build and test step outcome in a per-attempt artifact, and report failure only after the last of three attempts. Intermediate failures produce warnings and trigger the next fresh-runner attempt without failing their individual checks. Missing outcome artifacts count as failures, so runner or artifact errors cannot silently turn CI green. Apply this to iOS TemplateApp and RNTester; leave other lanes unchanged.

Changelog:

[INTERNAL] [FIXED] - Recovered iOS E2E retries no longer leave failed commit checks.

Test Plan:

  • actionlint v1.7.12 on .github/workflows/e2e-ios-templateapp.yml, .github/workflows/e2e-ios-rntester.yml, and .github/workflows/test-all.yml: passed, excluding existing repository warnings for custom runners, action descriptions and the unrelated run-e2e-tests input.
  • git diff --check: passed.
  • Ruby YAML.load_file and bash -n on workflow run blocks: passed.
  • node_modules/.bin/prettier --check could not run because node is not installed in this environment.
  • Native iOS E2E and actual GitHub check display require the PR CI run; please inspect recovered-failure and final-failure cases before merging.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant