Skip to content

Fix flaky ScrollView Maestro navigation with deep links - #58794

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:fix/maestro-scrollview-deeplink
Closed

cortinico wants to merge 1 commit into
react:mainfrom
cortinico:fix/maestro-scrollview-deeplink

Conversation

@cortinico

@cortinico cortinico commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

The Android Maestro run for 5954b12400d failed in scrollview-threshold-maintainvisible: scrollUntilVisible could not find the RNTester example in the Components list, before the flow reached any ScrollView assertions. See the failed job. The same flow passed on the next main commit, suggesting intermittent list-navigation failure.

Open the ScrollView maintain-visible-content-position module with RNTester deep links in both the threshold and min-index Maestro flows, and wait for the example control before proceeding. This bypasses scrolling through the RNTester catalog; the ScrollView checks themselves are unchanged.

Changelog:

[INTERNAL] - Use deep links to avoid flaky RNTester list navigation in ScrollView Maestro tests.

Test Plan:

  • yarn prettier --check packages/rn-tester/.maestro/scrollview-threshold-maintainvisible.yml packages/rn-tester/.maestro/scrollview-minindex-maintainvisible.yml — passed.
  • git diff --check — passed.
  • node -e 'const fs=require("fs"),yaml=require("yaml"); for(const f of process.argv.slice(1)){const docs=yaml.parseAllDocuments(fs.readFileSync(f,"utf8")); if(docs.length!==2||docs.some(d=>d.errors.length))throw Error(f+": invalid Maestro YAML"); const commands=docs[1].toJS(); if(!commands.some(c=>c.openLink==="rntester://example/ScrollViewMaintainVisibleContentPositionExample"))throw Error(f+": missing deep link"); console.log(f+": YAML valid, deep link present")}' packages/rn-tester/.maestro/scrollview-threshold-maintainvisible.yml packages/rn-tester/.maestro/scrollview-minindex-maintainvisible.yml — passed.
  • Maestro end-to-end flows not run locally: no Android device was attached, and RNTester was not installed on the available iOS simulator. CI should exercise both flows.
  • No screenshots needed: test automation only; no user-interface changes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Oct 1, 2026
@cortinico
cortinico marked this pull request as ready for review October 1, 2026 11:41
@meta-codesync

meta-codesync Bot commented Oct 1, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D122778911.

@meta-codesync meta-codesync Bot closed this in ba57eab Oct 1, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 1, 2026
@meta-codesync

meta-codesync Bot commented Oct 1, 2026

Copy link
Copy Markdown

@cortinico merged this pull request in ba57eab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant