Upgrade AndroidX Activity to 1.10.1 - #58689
Open
Abbondanzo wants to merge 2 commits into
Open
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Different AndroidX artifacts expose `ActivityResultLauncher.contract` as either a Kotlin property or a Java `getContract()` method. A Kotlin subclass cannot override both source representations even though they have the same JVM signature. Route the contract accessor through a package-private Java superclass so both representations resolve to the same JVM method. Use the bridge in production and test launchers, verify that the registered contract is preserved, and allowlist this required Java compatibility source. Changelog: [Android][Fixed] - Fix Activity Result launcher compilation across AndroidX source variants Differential Revision: D121845437
Summary: ReactAndroid exposes AndroidX Activity Result types in its public API but currently receives `androidx.activity:activity:1.7.0` only transitively through AppCompat. Declare Activity 1.10.1 as a direct API dependency. This aligns OSS builds with the version used internally and lets the Kotlin `contract` property compile directly, so the compatibility bridge from the parent diff can be removed. Changelog: [Android][Changed] - Upgrade AndroidX Activity to 1.10.1 Differential Revision: D121847691
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121847691. |
cortinico
approved these changes
Sep 26, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
rachel11026725
approved these changes
Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ReactAndroid exposes AndroidX Activity Result types in its public API but currently receives
androidx.activity:activity:1.7.0only transitively through AppCompat.Declare Activity 1.10.1 as a direct API dependency. This aligns OSS builds with the version used internally and lets the Kotlin
contractproperty compile directly, so the compatibility bridge from the parent diff can be removed.Changelog:
[Android][Changed] - Upgrade AndroidX Activity to 1.10.1
Differential Revision: D121847691