Use umbrella includes in textlayoutmanager headers (#58665) - #58665
Open
j-piasecki wants to merge 3 commits into
Open
j-piasecki wants to merge 3 commits into
j-piasecki wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121582300. |
facebook-github-tools
Bot
added
p: Software Mansion
Summary: Changelog: [Internal] Add a `React/RawValue.h` umbrella for the `rawValue` target, the slice of `react/renderer/core` that exists so core and `react/renderer/graphics` do not form a dependency cycle. `React/RendererCore.h` re-exports it instead of listing the two headers directly. Differential Revision: D121388426
Summary: Changelog: [Internal] Update `react/renderer/core` to use the `React/Debug.h`, `React/FeatureFlags.h`, `React/Graphics.h`, `React/MapBuffer.h`, `React/RendererDebug.h`, `React/Timing.h` and `React/Utils.h` umbrellas instead of direct includes. `debugStringConvertibleUtils.h` is an implementation helper, not public API, and is no longer re-exported from `React/RendererDebug.h`. Public API surface is unchanged. Differential Revision: D121395742
Summary: Pull Request resolved: react#58665 Switch the public headers of `react/renderer/textlayoutmanager` from fine-grained cross-module includes to the stable umbrella headers (`<React/Graphics.h>`, `<React/RendererCore.h>`, `<React/Utils.h>`). Implementation files keep using the fine-grained headers. Adds the `react/renderer/graphics` umbrella search path to `React-FabricComponents` for framework builds, since textlayoutmanager headers now reach it through the umbrella. No new module dependencies are needed. Changelog: [Internal] Differential Revision: D121582300
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D121582300
branch
from
September 25, 2026 13:21
166f26f to
2017d64
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Switch the public headers of
react/renderer/textlayoutmanagerfrom fine-grained cross-module includes to the stable umbrella headers (<React/Graphics.h>,<React/RendererCore.h>,<React/Utils.h>). Implementation files keep using the fine-grained headers.Adds the
react/renderer/graphicsumbrella search path toReact-FabricComponentsfor framework builds, since textlayoutmanager headers now reach it through the umbrella. No new module dependencies are needed.Changelog: [Internal]
Differential Revision: D121582300