Use public umbrellas in root headers (#58575) by coado · Pull Request #58575 · react/react-native

coado · 2026-09-17T16:11:22Z

Summary:

Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled.

Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers.

Changelog:
[Internal]

Reviewed By: cortinico

Differential Revision: D120532145

meta-codesync · 2026-09-17T16:12:04Z

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120532145.

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120532145

cortinico

Review automatically exported from Phabricator review in Meta.

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Ensure CocoaPods dynamic-framework builds can resolve those entry points both while compiling React-Fabric and from downstream consumers. The root subspec selects the core and view umbrella subspecs so their headers are packaged, while framework header search paths live on the top-level pod target because exported root headers are also compiled from sibling subspecs such as mounting. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Ensure CocoaPods dynamic-framework builds can resolve those entry points both while compiling React-Fabric and from downstream consumers. The root subspec selects the core and view umbrella subspecs so their headers are packaged, while framework header search paths live on the top-level pod target because exported root headers are also compiled from sibling subspecs such as mounting. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Ensure CocoaPods dynamic-framework builds can resolve those entry points both while compiling React-Fabric and from downstream consumers. The root subspec selects the core and view umbrella subspecs so their headers are packaged, while framework header search paths live on the top-level pod target because exported root headers are also compiled from sibling subspecs such as mounting. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Pull Request resolved: react#58575 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

…rs (react#58679) Summary: Fix dynamic-framework header resolution for stable C++ umbrella headers. Header paths are now added only to targets that depend on the owning framework, including transitively, without exposing a framework’s built headers to its own compilation. ## Changelog: [Internal] Test Plan: - Focused CocoaPods tests: 16 tests, 27 assertions, all passing. - Dynamic-framework CocoaPods generation: passing. - Verified React-RuntimeApple → React-RCTFabric → React-Fabric receives the React-Fabric umbrella path. - Verified React-Fabric does not receive its own built-framework path. - Verified the dynamic React-Fabric pod target resolves `$(PODS_TARGET_SRCROOT)/react/renderer/components/view` and `$(PODS_TARGET_SRCROOT)/react/renderer/core` before the framework exists. - `ruby --disable-gems -c packages/react-native/ReactCommon/React-Fabric.podspec` - `yarn format-check` - `arc lint xplat/js/react-native-github/packages/react-native/ReactCommon/React-Fabric.podspec` - Agent validators: arc-format, arc-lint, and arc-lint-testquality passed. The full CocoaPods Ruby test process could not start on this host because its RubyGems/JSON installation is broken; the existing focused CocoaPods coverage remains unchanged. Differential Revision: D121777587 Pulled By: coado

Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled. Stage the iOS ImageRequestParams header under its canonical imagemanager include path in the prebuilt header inventory. The public ImageManager umbrella exposes this platform-specific type transitively, so framework builds need it alongside the root imagemanager headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120532145

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2026

facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 17, 2026

meta-codesync Bot added the meta-exported label Sep 17, 2026

meta-codesync Bot changed the title ~~Use public umbrellas in root headers~~ Use public umbrellas in root headers (#58575) Sep 18, 2026

coado force-pushed the export-D120532145 branch from 0f3808e to 8dc2bd7 Compare September 18, 2026 14:29

cortinico approved these changes Sep 18, 2026

View reviewed changes

coado force-pushed the export-D120532145 branch from 8dc2bd7 to 059c817 Compare September 21, 2026 14:33

coado force-pushed the export-D120532145 branch from 059c817 to 429a5f1 Compare September 21, 2026 14:42

coado force-pushed the export-D120532145 branch from 429a5f1 to e5783c6 Compare September 21, 2026 19:02

coado force-pushed the export-D120532145 branch from e5783c6 to 46f0b80 Compare September 21, 2026 19:06

coado force-pushed the export-D120532145 branch from 46f0b80 to a2303a3 Compare September 22, 2026 12:33

meta-codesync Bot changed the title ~~Use public umbrellas in root headers (#58575)~~ Use public umbrellas in root headers Sep 22, 2026

coado force-pushed the export-D120532145 branch from a2303a3 to 7e04f6c Compare September 22, 2026 14:53

meta-codesync Bot changed the title ~~Use public umbrellas in root headers~~ Use public umbrellas in root headers (#58575) Sep 23, 2026

coado force-pushed the export-D120532145 branch from 7e04f6c to 5665b1e Compare September 23, 2026 12:29

coado force-pushed the export-D120532145 branch from 5665b1e to d221c56 Compare September 23, 2026 12:32

coado force-pushed the export-D120532145 branch from d221c56 to 9ddd921 Compare September 23, 2026 20:10

coado force-pushed the export-D120532145 branch from 9ddd921 to 12213f4 Compare September 24, 2026 08:28

coado force-pushed the export-D120532145 branch from 12213f4 to 04745a7 Compare September 24, 2026 08:31

coado force-pushed the export-D120532145 branch from 04745a7 to a12ed2b Compare September 24, 2026 11:21

coado force-pushed the export-D120532145 branch from a12ed2b to 0e2cda1 Compare September 24, 2026 11:25

meta-codesync Bot changed the title ~~Use public umbrellas in root headers (#58575)~~ Use public umbrellas in root headers Sep 25, 2026

coado force-pushed the export-D120532145 branch 2 times, most recently from 97c6adf to 2a58977 Compare September 25, 2026 11:38

meta-codesync Bot changed the title ~~Use public umbrellas in root headers~~ Use public umbrellas in root headers (#58575) Sep 25, 2026

coado force-pushed the export-D120532145 branch from 2a58977 to 106bccb Compare September 25, 2026 11:42

coado force-pushed the export-D120532145 branch from 106bccb to 7cb74c6 Compare September 25, 2026 14:03

coado and others added 2 commits September 25, 2026 08:27

coado force-pushed the export-D120532145 branch from 7cb74c6 to becd594 Compare September 25, 2026 15:27

Navigation Menu

Use public umbrellas in root headers (#58575) - #58575

Use public umbrellas in root headers (#58575)#58575
coado wants to merge 2 commits into
react:mainfrom
coado:export-D120532145

coado commented Sep 17, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

meta-codesync Bot commented Sep 17, 2026

Uh oh!

cortinico left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

coado commented Sep 17, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Sep 17, 2026

Uh oh!

cortinico left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coado commented Sep 17, 2026 •

edited by meta-codesync Bot

Loading