Use umbrella instead of a direct include in bridging module (#58549) - #58549
Open
j-piasecki wants to merge 4 commits into
Open
j-piasecki wants to merge 4 commits into
j-piasecki wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120311601. |
j-piasecki
force-pushed
the
export-D120311601
branch
from
September 16, 2026 08:33
18095b5 to
56d5f0c
Compare
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D120311601
branch
from
September 16, 2026 08:35
56d5f0c to
248f1d1
Compare
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
Summary: Changelog: [Internal] Update the timing module to use `React/Debug.h` umbrella include instead of a direct one. Differential Revision: D120137164
j-piasecki
force-pushed
the
export-D120311601
branch
from
September 16, 2026 12:42
248f1d1 to
9d9eaca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the bridging module to use
React/Bridging.handReact/RendererCore.humbrella includes instead of direct ones.Differential Revision: D120311601