Correctly link umbrella headers for iOS prebuild (#58548) - #58548
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120310677. |
facebook-github-tools
Bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D120310677
branch
from
September 16, 2026 07:47
129fb7b to
c3c1987
Compare
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D120310677
branch
from
September 16, 2026 08:33
c3c1987 to
053dd50
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
force-pushed
the
export-D120310677
branch
from
September 16, 2026 08:35
053dd50 to
78f7e94
Compare
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
force-pushed
the
export-D120310677
branch
from
September 16, 2026 12:42
78f7e94 to
bce561e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The umbrella headers under
ReactCommon/**/React/were only linked into their nestedReactCommon/...include dirs during the iOS SPM prebuild, so#include <React/Debug.h>(and the other umbrella headers) could not be resolved by theReactframework, breaking the build.This diff links each umbrella header directory into the
Reactheader dir.Changelog: [Internal]
Differential Revision: D120310677