Use umbrella instead of a direct include in reactperflogger module (#58532) - #58532
Open
j-piasecki wants to merge 2 commits into
Open
j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D120116155
branch
from
September 15, 2026 08:28
f6711ae to
94a800d
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120116155. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 15, 2026
…ct#58532) Summary: Pull Request resolved: react#58532 `ReactPerfettoLogger.h` and `ReactPerfetto.h` are "for frameworks" headers that reached the public `react/timing` module through `<react/timing/primitives.h>`. This diff changes that include to use the umbrella header, so the module compiles under `RN_STRICT_API`. Changelog: [Internal] Differential Revision: D120116155
j-piasecki
force-pushed
the
export-D120116155
branch
from
September 15, 2026 08:32
94a800d to
53b71a2
Compare
meta-codesync
Bot
changed the title
react/timing through its umbrella from reactperfloggerreact/timing through its umbrella from reactperflogger (#58532)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 15, 2026
…ct#58532) Summary: `ReactPerfettoLogger.h` and `ReactPerfetto.h` are "for frameworks" headers that reached the public `react/timing` module through `<react/timing/primitives.h>`. This diff changes that include to use the umbrella header, so the module compiles under `RN_STRICT_API`. Changelog: [Internal] Differential Revision: D120116155
j-piasecki
force-pushed
the
export-D120116155
branch
2 times, most recently
from
September 16, 2026 07:47
beb5c32 to
5987a66
Compare
meta-codesync
Bot
changed the title
react/timing through its umbrella from reactperflogger (#58532)
j-piasecki
force-pushed
the
export-D120116155
branch
from
September 16, 2026 08:33
5987a66 to
46c81d4
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
force-pushed
the
export-D120116155
branch
from
September 16, 2026 08:35
46c81d4 to
395ecb6
Compare
Summary: The umbrella headers under `ReactCommon/**/React/` were only linked into their nested `ReactCommon/...` include dirs during the iOS SPM prebuild, so `#include <React/Debug.h>` (and the other umbrella headers) could not be resolved by the `React` framework, breaking the build. This diff links each umbrella header directory into the `React` header dir. Changelog: [Internal] Differential Revision: D120310677
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
force-pushed
the
export-D120116155
branch
from
September 16, 2026 12:42
395ecb6 to
cf7c8a6
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Pull Request resolved: react#58532 Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…eact#58532) Summary: Changelog: [Internal] Update the reactperflogger module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120116155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the reactperflogger module to use
React/Timing.humbrella include instead of a direct one.Differential Revision: D120116155