fix: Metro inline-plugin doesn't support relative ES imports of Platform and it cause dead-code in production#57121
Closed
retyui wants to merge 1 commit into
Closed
fix: Metro inline-plugin doesn't support relative ES imports of Platform and it cause dead-code in production#57121retyui wants to merge 1 commit into
retyui wants to merge 1 commit into
Conversation
…orm and it cause dead-code in production
Contributor
|
Could we please update the inline plugin instead of reverting all these usages to require calls? I'm afraid this isn't very idiomatic, won't scale well and a lot of use cases will be reverted over time organically. |
Contributor
Author
|
@rubennorte As I mentioned in the description an inline-plugin has own PR: react/metro#1692 (comment) but no luck it will be merged so to devilry a simple dead-code elimination trick for all devs in the world this PR was created and hope will be available in the next release of RN |
Contributor
|
The right direction here is to fix the issue in react/metro#1692 not the import legacy requires in the react-native codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Metro inline-plugin doesn't work when an Platform has relative ES import
metro has own PR: react/metro#1692 (comment) but no lock it will be merged soon I think
Changelog:
[GENERAL] [FIXED] - No dead-code in production for internal usages of
PlatformTest Plan:
Before:
After