Gate ScrollView FPS listener fix behind feature flag#56817
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
Summary: react#56609 fixed `ReactHorizontalScrollView`, preserving `mFpsListener` across view recycling. This gates that fix behind the `fixScrollViewFpsListenerOnRecycleAndroid` feature flag to allow controlled rollout and detect potential performance regressions. When the flag is enabled, `mFpsListener` is preserved from the constructor argument (the fix). When disabled, it is set to `null` at construction time, effectively disabling FPS performance tracking as a safe fallback. Changelog: [Internal] Differential Revision: D105068773
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105068773. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#56609 fixed
ReactHorizontalScrollView, preservingmFpsListeneracross view recycling. This gates that fix behind thefixScrollViewFpsListenerOnRecycleAndroidfeature flag to allow controlled rollout and detect potential performance regressions.When the flag is enabled,
mFpsListeneris preserved from the constructor argument (the fix). When disabled, it is set tonullat construction time, effectively disabling FPS performance tracking as a safe fallback.Changelog: [Internal]
Differential Revision: D105068773