Consolidate Hermes version files and simplify JS release scripts (#56737)#56737
Closed
cipolleschi wants to merge 4 commits into
Closed
Consolidate Hermes version files and simplify JS release scripts (#56737)#56737cipolleschi wants to merge 4 commits into
cipolleschi wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104380961. |
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104380961
branch
from
f131045 to
4b96dc4
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 4b96dc4 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
force-pushed
the
export-D104380961
branch
from
4b96dc4 to
4b6600c
Compare
cipolleschi
added a commit
that referenced
this pull request
May 8, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
4b6600c to
fdc2893
Compare
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
fdc2893 to
bb23a4f
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in bb23a4f When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
bb23a4f to
0320e5a
Compare
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
0320e5a to
1c01b00
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 1c01b00 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
force-pushed
the
export-D104380961
branch
from
1c01b00 to
d7e846c
Compare
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
2 times, most recently
from
1c01b00 to
d7e846c
Compare
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
d7e846c to
113e857
Compare
cortinico
approved these changes
May 11, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…oad the correct commit data. Differential Revision: D104228879
added 2 commits
May 11, 2026 07:30
…oad the correct commit data. Differential Revision: D104244582
Summary: Pull Request resolved: #56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesversion` from `package.json` files array — only `.hermesv1version` remains - Simplify `hermes-utils.js`: remove `readHermesTag()`, `HERMES_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--tag` and `--hermes-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Reviewed By: cortinico Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
113e857 to
c03e23c
Compare
cipolleschi
added a commit
that referenced
this pull request
May 11, 2026
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesversion` from `package.json` files array — only `.hermesv1version` remains - Simplify `hermes-utils.js`: remove `readHermesTag()`, `HERMES_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--tag` and `--hermes-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Reviewed By: cortinico Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
c03e23c to
fb77800
Compare
) Summary: Pull Request resolved: #56737 - Remove `sdks/.hermesversion` from `package.json` files array — only `.hermesv1version` remains - Simplify `hermes-utils.js`: remove `readHermesTag()`, `HERMES_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--tag` and `--hermes-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Reviewed By: cortinico Differential Revision: D104380961
cipolleschi
force-pushed
the
export-D104380961
branch
from
fb77800 to
c84ec16
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in c84ec16 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
sdks/.hermesversionfrompackage.jsonfiles array — only.hermesv1versionremainshermes-utils.js: removereadHermesTag(),HERMES_TAG_FILE_PATH;setHermesTag()takes single argumentscripts/releases/utils/hermes-utils.js: single version ingetLatestHermesNightlyVersion()andupdateHermesRuntimeDependenciesVersions()bump-hermes-version.js: remove--tagand--hermes-versionCLI optionsrelease-hermes-for-branch-cut.js: remove legacy branch/workflow/PR logic, keep only single Hermes branchChangelog:
[General][Changed] - Simplified build JS Hermes infrastructure for the Release
Test plan
yarn jest --no-watchman hermes-utils-test.js— 5/5 tests passReviewed By: cortinico
Differential Revision: D104380961