Skip to content

Add exponential backoff to InspectorPackagerConnection reconnect and exception handling to connect (#56650) #56650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shubhamksavita wants to merge 1 commit into from
Closed

Add exponential backoff to InspectorPackagerConnection reconnect and exception handling to connect (#56650) #56650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <glog/logging.h>
#include <cerrno>
#include <chrono>
#include <exception>
#include <utility>

using namespace std::literals;
Expand All @@ -22,6 +23,7 @@ namespace facebook::react::jsinspector_modern {

static constexpr const std::chrono::duration RECONNECT_DELAY =
std::chrono::milliseconds{2000};
static constexpr const std::chrono::milliseconds MAX_RECONNECT_DELAY{120000};
static constexpr const char* INVALID = "<invalid>";

// InspectorPackagerConnection::Impl method definitions
Expand Down Expand Up @@ -301,6 +303,8 @@ void InspectorPackagerConnection::Impl::didReceiveMessage(

void InspectorPackagerConnection::Impl::didOpen() {
connected_ = true;
reconnectDelayMs_ = RECONNECT_DELAY;
suppressConnectionErrors_ = false;
}

void InspectorPackagerConnection::Impl::didClose() {
Expand Down Expand Up @@ -333,7 +337,15 @@ void InspectorPackagerConnection::Impl::connect() {
<< "Illegal state: Can't connect after having previously been closed.";
return;
}
webSocket_ = delegate_->connectWebSocket(url_, weak_from_this());
try {
webSocket_ = delegate_->connectWebSocket(url_, weak_from_this());
} catch (const std::exception& e) {
LOG(ERROR) << "Failed to create WebSocket connection: " << e.what();
reconnect();
} catch (...) {
LOG(ERROR) << "Failed to create WebSocket connection: unknown error";
reconnect();
}
}

void InspectorPackagerConnection::Impl::reconnect() {
Expand All @@ -357,6 +369,11 @@ void InspectorPackagerConnection::Impl::reconnect() {

reconnectPending_ = true;

auto currentDelay = reconnectDelayMs_;

// Exponential backoff: double the delay for next time, up to the max.
reconnectDelayMs_ = std::min(reconnectDelayMs_ * 2, MAX_RECONNECT_DELAY);

delegate_->scheduleCallback(
[weakSelf = weak_from_this()] {
auto strongSelf = weakSelf.lock();
Expand All @@ -370,7 +387,7 @@ void InspectorPackagerConnection::Impl::reconnect() {
strongSelf->connect();
}
},
RECONNECT_DELAY);
currentDelay);
}

void InspectorPackagerConnection::Impl::closeQuietly() {
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnectionImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ class InspectorPackagerConnection::Impl : public IWebSocketDelegate,
// Whether a reconnection is currently pending.
bool reconnectPending_{false};

// Current reconnect delay in milliseconds, used for exponential backoff.
std::chrono::milliseconds reconnectDelayMs_{2000};

SessionId nextSessionId_{1};
};

Expand Down
Loading