Improve typing of renderApplication#56636
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
Summary: General typing improvements to the `renderApplication` module: - Refactors `renderApplication` to take a single options object instead of positional arguments, and removes the unused `fabric` and `_unused` parameters. The `fabric` parameter was already always treated as `true` internally, and the `_unused` slot was a reserved positional placeholder for a removed `scopedPerformanceLogger` argument. - Migrates the file to `flow strict-local`. - Types `RootComponent` and `WrapperComponent` using component syntax instead of `React.ComponentType`. - Replaces `rootTag: any` with `number | RootTag`, normalizing via the existing `createRootTag` helper for `<AppContainer>` and `Number()` for `Renderer.renderElement`. - Simplifies `ActivityType` (drops the unnecessary spread) and tightens null/boolean checks (`debugName != null`, `useOffscreen === true`). Exports a new `RenderApplicationOptions<Props>` type and updates all internal callers accordingly. Changelog: [Internal] Reviewed By: javache Differential Revision: D102325691
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102325691. |
|
This pull request has been merged in 2a5c4b3. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 2a5c4b3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
General typing improvements to the
renderApplicationmodule:renderApplicationto take a single options object insteadof positional arguments, and removes the unused
fabricand_unusedparameters. The
fabricparameter was already always treated astrueinternally, and the_unusedslot was a reserved positionalplaceholder for a removed
scopedPerformanceLoggerargument.flow strict-local.RootComponentandWrapperComponentusing component syntaxinstead of
React.ComponentType.rootTag: anywithnumber | RootTag, normalizing via theexisting
createRootTaghelper for<AppContainer>andNumber()for
Renderer.renderElement.ActivityType(drops the unnecessary spread) and tightensnull/boolean checks (
debugName != null,useOffscreen === true).Exports a new
RenderApplicationOptions<Props>type and updates allinternal callers accordingly.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D102325691