Skip to content

fix: reset StartupLogger on JS reload so runJsBundleStart marker is recorded #56616

Open
mohanrajvenkatesan23-04 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reset StartupLogger on JS reload so runJsBundleStart marker is recorded #56616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ void ReactInstance::loadScript(
beforeLoad(runtime);
}
TraceSection s("ReactInstance::loadScript");
// Reset the StartupLogger so that JS reloads re-record all START/STOP
// timings. Without this, the APP_STARTUP_START handler resets the logger
// mid-sequence (after RUN_JS_BUNDLE_START / INIT_REACT_RUNTIME_START have
// already been rejected as duplicates), leaving NaN start times paired
// with valid end times. See issue #56339.
ReactMarker::StartupLogger::getInstance().reset();
bool hasLogger(ReactMarker::logTaggedMarkerBridgelessImpl != nullptr);
if (hasLogger) {
ReactMarker::logTaggedMarkerBridgeless(
Expand Down