Fix unused parameter warnings in StubWebSocketClient.h (#56527)#56527
Closed
christophpurrer wants to merge 1 commit into
Closed
Fix unused parameter warnings in StubWebSocketClient.h (#56527)#56527christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101110612. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
bd9fce2 to
7b40f47
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: react#56527 Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
7b40f47 to
fd49cf1
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
fd49cf1 to
2ece3ea
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
2ece3ea to
df0aa0c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
df0aa0c to
47f0c61
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Pull Request resolved: react#56527 Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
47f0c61 to
ee4ab48
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Pull Request resolved: react#56527 Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
2 times, most recently
from
92414cb to
0c8ca06
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Reviewed By: philIip Differential Revision: D101110612
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 22, 2026
Summary: Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Reviewed By: philIip Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
0c8ca06 to
9d244fe
Compare
Summary: Pull Request resolved: react#56527 Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused. Changelog: [Internal] Reviewed By: philIip Differential Revision: D101110612
christophpurrer
force-pushed
the
export-D101110612
branch
from
9d244fe to
8b60623
Compare
|
This pull request has been merged in f41364d. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in f41364d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removed parameter names from unused parameters in StubWebSocketClient stub implementation to fix clang-diagnostic-unused-parameter warnings. This stub class implements IWebSocketClient interface with empty method bodies, so all parameters were unused.
Changelog: [Internal]
Reviewed By: philIip
Differential Revision: D101110612