Add batched animated prop update path on Android (#56468)#56468
Open
bartlomiejbloniarz wants to merge 2 commits into
Open
Add batched animated prop update path on Android (#56468)#56468bartlomiejbloniarz wants to merge 2 commits into
bartlomiejbloniarz wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101157453. |
Summary: Introduces the cross-platform delegate chain for batched animated property updates without any platform implementation: - Adds `schedulerShouldSynchronouslyUpdateAnimatedPropsOnUIThread` to `SchedulerDelegate` and forwards from `Scheduler`. - Adds `uiManagerShouldSynchronouslyUpdateAnimatedPropsOnUIThread` to `UIManagerDelegate` and `synchronouslyUpdateAnimatedPropsOnUIThread` to `UIManager`. - Adds no-op stubs in iOS (`RCTScheduler.mm`), macOS (`RCTScheduler.mm`), Windows (`FabricUIManagerModule`) and CxxPlatform (`SchedulerDelegateImpl`). No behavioural impact; Android implementation lands in a follow-up. Changelog: [Internal] Differential Revision: D104672455
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D101157453
branch
from
9822880 to
a6bf42a
Compare
bartlomiejbloniarz
force-pushed
the
export-D101157453
branch
from
a6bf42a to
a16e381
Compare
Summary: Pull Request resolved: #56468 Implements the Android batched animated prop update path on top of the cross-platform delegate chain introduced in the previous commit. Gated behind the `optimizedAnimatedPropUpdates` feature flag, so this change has no behavioural impact when the flag is off. - `BatchedAnimatedPropsMountItem.kt`: decodes the int/double buffer protocol and applies updates to views. - `AnimatedPropBufferEncoder` + `AnimatedPropCommands`: C++ side that encodes `AnimatedProps` into the buffer protocol. - `FabricMountingManager::synchronouslyUpdateAnimatedPropsOnUIThread`: builds the buffers and JNI-calls into Java. - `FabricUIManagerBinding`: wires the `SchedulerDelegate` override into `FabricMountingManager`. - `FabricUIManager.synchronouslyUpdateViewBatch`: Java entry point invoked from JNI that constructs and executes a `BatchedAnimatedPropsMountItem`. Changelog: [Android][Added] - Add a batched animated prop update path that applies all pending C++ animation backend updates via a single mount item (gated by `optimizedAnimatedPropUpdates`) Differential Revision: D101157453
meta-codesync
Bot
changed the title
bartlomiejbloniarz
force-pushed
the
export-D101157453
branch
from
a16e381 to
b7548e8
Compare
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in b7548e8 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 07137c2 When will my fix make it into a release? | How to file a pick request? |
tomekzaw
reviewed
May 12, 2026
| } | ||
|
|
||
| when (cmd) { | ||
| in CMD_OPACITY..CMD_SHADOW_RADIUS -> |
Contributor
There was a problem hiding this comment.
How about listing all enum values explicitly instead of using ..? The current version is very prone to breaking when we introduce new props or change the underlying enum values
tomekzaw
reviewed
May 12, 2026
| static constexpr int CMD_BORDER_START_COLOR = 45; | ||
| static constexpr int CMD_BORDER_END_COLOR = 46; | ||
|
|
||
| // Transform commands |
Contributor
There was a problem hiding this comment.
Do we also want to add support for transformOrigin?
tomekzaw
reviewed
May 12, 2026
| } | ||
| } | ||
|
|
||
| override fun toString(): String { |
Contributor
There was a problem hiding this comment.
I don't like it that this logic is duplicated
tomekzaw
reviewed
May 12, 2026
| CMD_BORDER_RIGHT_COLOR -> ViewProps.BORDER_RIGHT_COLOR | ||
| CMD_BORDER_START_COLOR -> ViewProps.BORDER_START_COLOR | ||
| CMD_BORDER_END_COLOR -> ViewProps.BORDER_END_COLOR | ||
| else -> "unknown" |
tomekzaw
reviewed
May 12, 2026
| CMD_SKEW_Y -> "skewY" | ||
| CMD_MATRIX -> "matrix" | ||
| CMD_PERSPECTIVE -> "perspective" | ||
| else -> "unknown" |
tomekzaw
reviewed
May 12, 2026
Comment on lines
+286
to
+289
| CMD_SCALE_X -> ViewProps.SCALE_X | ||
| CMD_SCALE_Y -> ViewProps.SCALE_Y | ||
| CMD_ROTATE -> "rotate" | ||
| CMD_ROTATE_X -> "rotateX" |
Contributor
There was a problem hiding this comment.
Why do we sometimes use ViewProps.* and sometimes string literal?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implements the Android batched animated prop update path on top of the cross-platform delegate chain introduced in the previous commit. Gated behind the
optimizedAnimatedPropUpdatesfeature flag, so this change has no behavioural impact when the flag is off.BatchedAnimatedPropsMountItem.kt: decodes the int/double buffer protocol and applies updates to views.AnimatedPropBufferEncoder+AnimatedPropCommands: C++ side that encodesAnimatedPropsinto the buffer protocol.FabricMountingManager::synchronouslyUpdateAnimatedPropsOnUIThread: builds the buffers and JNI-calls into Java.FabricUIManagerBinding: wires theSchedulerDelegateoverride intoFabricMountingManager.FabricUIManager.synchronouslyUpdateViewBatch: Java entry point invoked from JNI that constructs and executes aBatchedAnimatedPropsMountItem.Changelog:
[Android][Added] - Add a batched animated prop update path that applies all pending C++ animation backend updates via a single mount item (gated by
optimizedAnimatedPropUpdates)Differential Revision: D101157453