Migrate YogaConstants to Kotlin#52998
Closed
mateoguzmana wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
Contributor
|
This is redundant, as react/yoga#1829 will automatically populate the copy in the rn repo when merged, let's close this. |
rshest
suggested changes
Aug 4, 2025
rshest
left a comment
rshest
left a comment
Contributor
There was a problem hiding this comment.
As noted above, this will get automagically populated from react/yoga#1829 :)
Collaborator
Author
|
Makes sense, thanks! closing as per comment. |
facebook-github-bot
pushed a commit
to react/yoga
that referenced
this pull request
Aug 7, 2025
Summary: X-link: react/react-native#53133 # Changelog: [Internal] - As part of the ongoing effort to migrate the React Native codebase to Kotlin, this PR introduces the initial setup required for Kotlin support in Yoga. - Added initial basic Kotlin configuration to the project. - Migrated `YogaConstants` as an initial file to try out the first migration steps. Pull Request resolved: #1829 Test Plan: - Tested the migrated class directly against facebook/react-native, see the PR [here](react/react-native#52998). - Run: `./gradlew :yoga:assembleDebug` & `./gradlew :yoga:compileDebugSources` I am not able to run the Java tests in this repo (even before the initial Kotlin setup) – not sure if I am missing something there but any pointers are welcome – it seems like there is some missing configuration. Currently trying with `./gradlew :yoga:test` Reviewed By: cortinico Differential Revision: D79545992 Pulled By: rshest fbshipit-source-id: 8257ff53e6b6f2436980be98b6c94e1ac526b207
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
Summary: Pull Request resolved: #53133 # Changelog: [Internal] - As part of the ongoing effort to migrate the React Native codebase to Kotlin, this PR introduces the initial setup required for Kotlin support in Yoga. - Added initial basic Kotlin configuration to the project. - Migrated `YogaConstants` as an initial file to try out the first migration steps. X-link: react/yoga#1829 Test Plan: - Tested the migrated class directly against facebook/react-native, see the PR [here](#52998). - Run: `./gradlew :yoga:assembleDebug` & `./gradlew :yoga:compileDebugSources` I am not able to run the Java tests in this repo (even before the initial Kotlin setup) – not sure if I am missing something there but any pointers are welcome – it seems like there is some missing configuration. Currently trying with `./gradlew :yoga:test` Reviewed By: cortinico Differential Revision: D79545992 Pulled By: rshest fbshipit-source-id: 8257ff53e6b6f2436980be98b6c94e1ac526b207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Initial migration for the Yoga files, starting with
YogaConstants. Please see react/yoga#1829 first, as the initial Kotlin setup is there.Changelog:
[INTERNAL] - Migrate com.facebook.yoga.YogaConstants to Kotlin
Test Plan: