Skip to content

Handle alerts correctly on web in Button example #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simek merged 6 commits into from
Jan 4, 2026
Merged

Handle alerts correctly on web in Button example #4946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6fcd491
Handle alerts correctly on web in Button example
yash04577 Jan 3, 2026
8814ff9
Handle alerts correctly on web in Button example
yash04577 Jan 3, 2026
d666d1c
Merge branch 'main' of https://github.com/yash04577/react-native-webs…
yash04577 Jan 4, 2026
005d272
Merge branch 'facebook:main' into fix/button-alert-web
yash04577 Jan 4, 2026
3740bee
branch update
yash04577 Jan 4, 2026
f40f70e
fix: added web alert on current version
yash04577 Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions docs/button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,21 @@ If this button doesn't look right for your app, you can build your own button us

## Example

```SnackPlayer name=Button%20Example
```SnackPlayer name=Button%20Example&ext=js
import React from 'react';
import {StyleSheet, Button, View, Text, Alert} from 'react-native';
import {StyleSheet, Button, View, Text, Alert, Platform} from 'react-native';
import {SafeAreaView, SafeAreaProvider} from 'react-native-safe-area-context';

const Separator = () => <View style={styles.separator} />;

function showAlert(message) {
if (Platform.OS === 'web') {
window.alert(message);
} else {
Alert.alert(message);
}
}

const App = () => (
<SafeAreaProvider>
<SafeAreaView style={styles.container}>
Expand All @@ -35,7 +43,7 @@ const App = () => (
</Text>
<Button
title="Press me"
onPress={() => Alert.alert('Simple Button pressed')}
onPress={() => showAlert('Simple Button pressed')}
/>
</View>
<Separator />
Expand All @@ -48,7 +56,7 @@ const App = () => (
<Button
title="Press me"
color="#f194ff"
onPress={() => Alert.alert('Button with adjusted color pressed')}
onPress={() => showAlert('Button with adjusted color pressed')}
/>
</View>
<Separator />
Expand All @@ -59,7 +67,7 @@ const App = () => (
<Button
title="Press me"
disabled
onPress={() => Alert.alert('Cannot press this one')}
onPress={() => showAlert('Cannot press this one')}
/>
</View>
<Separator />
Expand All @@ -70,11 +78,11 @@ const App = () => (
<View style={styles.fixToText}>
<Button
title="Left button"
onPress={() => Alert.alert('Left button pressed')}
onPress={() => showAlert('Left button pressed')}
/>
<Button
title="Right button"
onPress={() => Alert.alert('Right button pressed')}
onPress={() => showAlert('Right button pressed')}
/>
</View>
</View>
Expand Down
1 change: 1 addition & 0 deletions packages/lint-examples/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export default defineConfig([
...reactNativeConfig.rules,
// Many existing inline styles in examples
'react-native/no-inline-styles': 'off',
'no-alert': 'off',
},

settings: {
Expand Down
22 changes: 15 additions & 7 deletions website/versioned_docs/version-0.82/button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,21 @@ If this button doesn't look right for your app, you can build your own button us

## Example

```SnackPlayer name=Button%20Example
```SnackPlayer name=Button%20Example&ext=js
import React from 'react';
import {StyleSheet, Button, View, Text, Alert} from 'react-native';
import {StyleSheet, Button, View, Text, Alert, Platform} from 'react-native';
import {SafeAreaView, SafeAreaProvider} from 'react-native-safe-area-context';

const Separator = () => <View style={styles.separator} />;

function showAlert(message) {
if (Platform.OS === 'web') {
window.alert(message);
} else {
Alert.alert(message);
}
}

const App = () => (
<SafeAreaProvider>
<SafeAreaView style={styles.container}>
Expand All @@ -35,7 +43,7 @@ const App = () => (
</Text>
<Button
title="Press me"
onPress={() => Alert.alert('Simple Button pressed')}
onPress={() => showAlert('Simple Button pressed')}
/>
</View>
<Separator />
Expand All @@ -48,7 +56,7 @@ const App = () => (
<Button
title="Press me"
color="#f194ff"
onPress={() => Alert.alert('Button with adjusted color pressed')}
onPress={() => showAlert('Button with adjusted color pressed')}
/>
</View>
<Separator />
Expand All @@ -59,7 +67,7 @@ const App = () => (
<Button
title="Press me"
disabled
onPress={() => Alert.alert('Cannot press this one')}
onPress={() => showAlert('Cannot press this one')}
/>
</View>
<Separator />
Expand All @@ -70,11 +78,11 @@ const App = () => (
<View style={styles.fixToText}>
<Button
title="Left button"
onPress={() => Alert.alert('Left button pressed')}
onPress={() => showAlert('Left button pressed')}
/>
<Button
title="Right button"
onPress={() => Alert.alert('Right button pressed')}
onPress={() => showAlert('Right button pressed')}
/>
</View>
</View>
Expand Down
22 changes: 15 additions & 7 deletions website/versioned_docs/version-0.83/button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,21 @@ If this button doesn't look right for your app, you can build your own button us

## Example

```SnackPlayer name=Button%20Example
```SnackPlayer name=Button%20Example&ext=js
import React from 'react';
import {StyleSheet, Button, View, Text, Alert} from 'react-native';
import {StyleSheet, Button, View, Text, Alert, Platform} from 'react-native';
import {SafeAreaView, SafeAreaProvider} from 'react-native-safe-area-context';

const Separator = () => <View style={styles.separator} />;

function showAlert(message) {
if (Platform.OS === 'web') {
window.alert(message);
} else {
Alert.alert(message);
}
}

const App = () => (
<SafeAreaProvider>
<SafeAreaView style={styles.container}>
Expand All @@ -35,7 +43,7 @@ const App = () => (
</Text>
<Button
title="Press me"
onPress={() => Alert.alert('Simple Button pressed')}
onPress={() => showAlert('Simple Button pressed')}
/>
</View>
<Separator />
Expand All @@ -48,7 +56,7 @@ const App = () => (
<Button
title="Press me"
color="#f194ff"
onPress={() => Alert.alert('Button with adjusted color pressed')}
onPress={() => showAlert('Button with adjusted color pressed')}
/>
</View>
<Separator />
Expand All @@ -59,7 +67,7 @@ const App = () => (
<Button
title="Press me"
disabled
onPress={() => Alert.alert('Cannot press this one')}
onPress={() => showAlert('Cannot press this one')}
/>
</View>
<Separator />
Expand All @@ -70,11 +78,11 @@ const App = () => (
<View style={styles.fixToText}>
<Button
title="Left button"
onPress={() => Alert.alert('Left button pressed')}
onPress={() => showAlert('Left button pressed')}
/>
<Button
title="Right button"
onPress={() => Alert.alert('Right button pressed')}
onPress={() => showAlert('Right button pressed')}
/>
</View>
</View>
Expand Down