Skip to content

docs: use the correct callback function for RCTMyCustomView onChange#4933

Merged
Simek merged 4 commits into
react:mainfrom
dev-shady:patch-1
Dec 24, 2025
Merged

docs: use the correct callback function for RCTMyCustomView onChange#4933
Simek merged 4 commits into
react:mainfrom
dev-shady:patch-1

Conversation

@dev-shady

Copy link
Copy Markdown
Contributor

pass the local onChange wrapper so that it can extract the nativeEvent.message before calling the parent's props.onChangeMessage

…prop

pass the local onChange wrapper so that it can extract the nativeEvent.message before calling the parent's props.onChangeMessage
@meta-cla

meta-cla Bot commented Dec 17, 2025

Copy link
Copy Markdown

Hi @dev-shady!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Dec 17, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit a2915a8
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/694b0d9c61d2b10008f61694
😎 Deploy Preview https://deploy-preview-4933--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla Bot added the CLA Signed label Dec 17, 2025
@meta-cla

meta-cla Bot commented Dec 17, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Simek

Simek commented Dec 23, 2025

Copy link
Copy Markdown
Collaborator

Hey @dev-shady, thanks for the correction! 👍

Can you also apply the change to unversioned doc, and rest of the versioned files?

@dev-shady

Copy link
Copy Markdown
Contributor Author

@Simek Sure, let me update.

@dev-shady

Copy link
Copy Markdown
Contributor Author

@Simek updated. pls check.

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up, LGTM! 👍

@Simek Simek merged commit 662fbdd into react:main Dec 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants