Migrate plugins to TypeScript and update configurations#4866
Merged
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…, and implement image asset checking and redirect updating scripts
Simek
reviewed
Nov 10, 2025
Simek
left a comment
Simek
left a comment
Collaborator
There was a problem hiding this comment.
Hey @clicktodev, thanks for working on those improvements! 🙏
Will check this locally on macOS and Windows soon, and will get back to you with the proper review, for now I just have left few comments after looking at diffs on GitHub.
…ating function signatures
…TMLElement casting and adding Window interface for ExpoSnack
Removed unused import statement for expo-snack types.
Simek
approved these changes
Nov 11, 2025
Simek
left a comment
Simek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for working on those improvements! 👍
I have filled out missing types and addressed TODO comments, so this changes should be ready to ship. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the codebase of plugins to TypeScript for improved type safety and maintainability. Update package configurations to reflect the changes in entry points and dependencies.
remark-snackplayer and remark-lint-no-dead-urls have some types errors related to nodes but i don't the time to solve them rn