Skip to content

Fix Platform API example#4851

Merged
Simek merged 1 commit into
react:mainfrom
akkadaya:bugfix/fix_platform_api_docs
Oct 15, 2025
Merged

Fix Platform API example#4851
Simek merged 1 commit into
react:mainfrom
akkadaya:bugfix/fix_platform_api_docs

Conversation

@akkadaya

Copy link
Copy Markdown
Contributor

Fix SafeAreaView style

@meta-cla

meta-cla Bot commented Oct 14, 2025

Copy link
Copy Markdown

Hi @akkadaya!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 14, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 1a14dde
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68ef566b2677ca0008a3b54b
😎 Deploy Preview https://deploy-preview-4851--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@akkadaya akkadaya force-pushed the bugfix/fix_platform_api_docs branch from dc36a6f to e1da43b Compare October 14, 2025 22:50
@meta-cla meta-cla Bot added the CLA Signed label Oct 14, 2025
@akkadaya akkadaya force-pushed the bugfix/fix_platform_api_docs branch from e1da43b to c5ae922 Compare October 14, 2025 22:57
@akkadaya

Copy link
Copy Markdown
Contributor Author

I can't find my changes in "😎 Deploy Preview" can someone advise if I'm doing something wrong?

@Simek

Simek commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Hello @akkadaya, nice catch, thanks for fixing it! 👍

I can't find my changes in "😎 Deploy Preview" can someone advise if I'm doing something wrong?

You have edited the unversioned file only, so the changes are only visible in "Next" docs version:

Let's backport this change to all versioned docs located in - https://github.com/facebook/react-native-website/tree/main/website/versioned_docs. That way all available doc page versions on the website would include the fix.

@akkadaya akkadaya force-pushed the bugfix/fix_platform_api_docs branch from c5ae922 to d7630ac Compare October 15, 2025 06:18
@akkadaya

Copy link
Copy Markdown
Contributor Author

Done! thanks @Simek

@Simek

Simek commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the updates @akkadaya! Can you fix the lint issue (missing coma after flex: 1)? With that change in, it should be ready to ship. 🙂

Fix SafeAreaView style
@akkadaya akkadaya force-pushed the bugfix/fix_platform_api_docs branch from d7630ac to 1a14dde Compare October 15, 2025 08:08
@Simek Simek merged commit 37ab032 into react:main Oct 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants